Fix #1469 - the old api code path didnt get the variable defined that is being used to locate the api endpoints #1470
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2025 09:27
…ble defined that is being used to locate the api endpoints
sc68cal
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Related Issue
#1469
New Behavior
The variable that is being used to identify the api endpoint can now be used in the code path for older netbox servers so the inventory plugin shouldn't crash when attempting to communicate with old servers.
...
Contrast to Current Behavior
When using old netbox servers we should be able to retrieve inventory information rather than crashing with errors about not being able to access variables.
...
Discussion: Benefits and Drawbacks
This is only relevant to old old servers but we currently have a broken code path in the current version of the plugin.
One alternative in my mind would be to remove all of the checks for version lt 3.5.0, update the documentation to indicate that it's really not supported and probably create a new check for the old api version/path that just returns an error saying "upgrade to a newer version of netbox"
...
Changes to the Documentation
None - stopping a bug from triggering.
Proposed Release Note Entry
Fix of logic when interacting with old netbox servers.
...
Double Check
develbranch.