Skip to content

Fix #1469 - the old api code path didnt get the variable defined that is being used to locate the api endpoints #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

Fix #1469 - the old api code path didnt get the variable defined that is being used to locate the api endpoints #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db81041
Fix #1469 - the old api code path didnt get the variable defined that…
Oct 1, 2025
5812a53
changlog fragment for fix of #1469
Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1469-fix-old-apis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- Fix broken code path when using old api path on old netbox systems
4 changes: 2 additions & 2 deletions plugins/inventory/nb_inventory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,10 +1648,10 @@ def fetch_api_docs(self):
pass

self.api_version = version.parse(netbox_api_version)
parsed_endpoint_url = urlparse(self.api_endpoint)
base_path = parsed_endpoint_url.path

if self.api_version >= version.parse("3.5.0"):
parsed_endpoint_url = urlparse(self.api_endpoint)
base_path = parsed_endpoint_url.path
self.allowed_device_query_parameters = [
p["name"]
for p in openapi["paths"][base_path + "/api/dcim/devices/"]["get"][
Expand Down
Loading