Fixes #674: Include more types in trace() method #684
Conversation
| interface_connection = InterfaceConnection | ||
|
|
||
|
|
||
| class PowerFeeds(TraceableRecord): |
There was a problem hiding this comment.
This is probably my lack of pynetbox knowledge showing through, but why do we need a separate sub-class of TraceAbleRecord for PowerFeeds? Is there some reason that the addition to uri_to_obj_class_map is not sufficient?
If it is required, i Is there a reason it's body is just pass versus some other configuration declaration?
There was a problem hiding this comment.
I don't think there are any sub-objects needs to be set to the correct type, it is like Cables or InterfaceConnection. Those have to set __str but PowerFeed has name field which is the default str.
There was a problem hiding this comment.
Looks good, with one exception--there's no way to trace a circuit termination. Circuit terminations are definitely included as part of a represented trace with this change, but you can not call .trace() on a CircuitTermination instance.
But, since the original FR was for them being represented, that seems out of scope for this.
Fixes: #674
This is PR #675 with merge fixes from master.