Skip to content

Fixes #674: Include more types in trace() method #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

Fixes #674: Include more types in trace() method #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d69075c
Update uri_to_obj_class_map to support additional supported terminati…
bcollet Apr 10, 2025
7d83bc5
Add mapping for PowerFeeds
bcollet Apr 21, 2025
306b837
Merge branch 'master' into 675-trace
arthanson May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pynetbox/models/dcim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,22 @@
from pynetbox.core.endpoint import DetailEndpoint, RODetailEndpoint
from pynetbox.core.query import Request
from pynetbox.core.response import JsonField, Record
from pynetbox.models.circuits import Circuits
from pynetbox.models.circuits import Circuits, CircuitTerminations
from pynetbox.models.ipam import IpAddresses


class TraceableRecord(Record):
def _get_obj_class(self, url):
uri_to_obj_class_map = {
"circuits/circuit-terminations": CircuitTerminations,
"dcim/cables": Cables,
"dcim/console-ports": ConsolePorts,
"dcim/console-server-ports": ConsoleServerPorts,
"dcim/front-ports": FrontPorts,
"dcim/interfaces": Interfaces,
"dcim/power-feeds": PowerFeeds,
"dcim/power-outlets": PowerOutlets,
"dcim/power-ports": PowerPorts,
"dcim/rear-ports": RearPorts,
}

Expand Down Expand Up @@ -154,6 +160,10 @@ class Interfaces(TraceableRecord):
interface_connection = InterfaceConnection


class PowerFeeds(TraceableRecord):
Copy link
Member

@jnovinger jnovinger May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably my lack of pynetbox knowledge showing through, but why do we need a separate sub-class of TraceAbleRecord for PowerFeeds? Is there some reason that the addition to uri_to_obj_class_map is not sufficient?

If it is required, i Is there a reason it's body is just pass versus some other configuration declaration?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any sub-objects needs to be set to the correct type, it is like Cables or InterfaceConnection. Those have to set __str but PowerFeed has name field which is the default str.

pass


class PowerOutlets(TraceableRecord):
device = Devices

Expand Down
3 changes: 2 additions & 1 deletion pynetbox/models/mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
DeviceTypes,
FrontPorts,
Interfaces,
PowerFeeds,
PowerOutlets,
PowerPorts,
RackReservations,
Expand Down Expand Up @@ -48,7 +49,7 @@
"dcim.modulebaytemplate": None,
"dcim.moduletype": None,
"dcim.platform": None,
"dcim.powerfeed": None,
"dcim.powerfeed": PowerFeeds,
"dcim.poweroutlet": PowerOutlets,
"dcim.poweroutlettemplate": None,
"dcim.powerpanel": None,
Expand Down