Skip to content

NETOBSERV-2555 Filters observed even when features not enabled in flowcollector#1256

Merged
jotak merged 3 commits intonetobserv:mainfrom
jpinsonneau:2555
Feb 5, 2026
Merged

NETOBSERV-2555 Filters observed even when features not enabled in flowcollector#1256
jotak merged 3 commits intonetobserv:mainfrom
jpinsonneau:2555

Conversation

@jpinsonneau
Copy link
Member

Description

  • Add features on filters config
  • Check for filter feature first
  • Then check on related column if available

Dependencies

netobserv/network-observability-operator#2410

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau
Copy link
Member Author

/cherry-pick release-1.11

@openshift-cherrypick-robot

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Amoghrd
Copy link
Member

Amoghrd commented Feb 3, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

New image:
quay.io/netobserv/network-observability-console-plugin:4c5a327

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4c5a327 make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 3, 2026
@leandroberetta
Copy link
Contributor

@jpinsonneau same as in the operator, I added the feature field in the config.

Copy link
Member

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Feb 4, 2026
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

New image:
quay.io/netobserv/network-observability-console-plugin:6fb3214

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6fb3214 make set-plugin-image

@openshift-ci openshift-ci bot removed the lgtm label Feb 4, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2026

New changes are detected. LGTM label has been removed.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 4, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oliviercazade. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Amoghrd
Copy link
Member

Amoghrd commented Feb 4, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

New image:
quay.io/netobserv/network-observability-console-plugin:4f15be4

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4f15be4 make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Feb 4, 2026

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Feb 4, 2026
@jpinsonneau
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2026

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 4ed7a2c link true /test plugin-cypress

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Member Author

@Amoghrd do you know why cypress fails here ?

@jotak jotak merged commit daf09af into netobserv:main Feb 5, 2026
10 of 12 checks passed
@jotak
Copy link
Member

jotak commented Feb 5, 2026

/cherry-pick release-1.11

@openshift-cherrypick-robot

@jpinsonneau: new pull request created: #1263

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jotak: new pull request could not be created: failed to create pull request against netobserv/network-observability-console-plugin#release-1.11 from head openshift-cherrypick-robot:cherry-pick-1256-to-release-1.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-1256-to-release-1.11."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Tells that the PR needs a review ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants