Skip to content

NETOBSERV-2555 Filters observed even when features not enabled in flowcollector #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jotak merged 2 commits into from
Feb 5, 2026
Merged

NETOBSERV-2555 Filters observed even when features not enabled in flowcollector #2410

jotak merged 2 commits into from
Feb 5, 2026

Conversation

@jpinsonneau
Copy link
Member

@jpinsonneau jpinsonneau commented Feb 3, 2026 •
edited
Loading

Description

Add features on filters config

Dependencies

netobserv/network-observability-console-plugin#1256

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau mentioned this pull request Feb 3, 2026
Merged
10 tasks
@jpinsonneau jpinsonneau marked this pull request as ready for review February 3, 2026 17:23
@jpinsonneau jpinsonneau added the needs-review Tells that the PR needs a review label Feb 3, 2026
@jpinsonneau
Copy link
Member Author

jpinsonneau commented Feb 3, 2026

/cherry-pick release-1.11

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2026

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Amoghrd
Copy link
Member

Amoghrd commented Feb 3, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

New images:

  • quay.io/netobserv/network-observability-operator:59c477d
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-59c477d
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-59c477d

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:59c477d make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-59c477d

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-59c477d
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@leandroberetta
Copy link
Contributor

leandroberetta commented Feb 3, 2026

I'm testing this one, but Zone is still showing up:

image

I'm using:

quay.io/netobserv/network-observability-operator:59c477d
quay.io/netobserv/network-observability-console-plugin:4c5a327

FlowCollector default (deploy-sample-cr)

Am I doing something wrong?.

@Amoghrd
Copy link
Member

Amoghrd commented Feb 3, 2026

Yup I see the same as Leandro. Zone is still observed

@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (4b09e40) to head (4e62c0d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2410      +/-   ##
==========================================
- Coverage   71.80%   71.78%   -0.02%     
==========================================
  Files          93       93              
  Lines       10567    10567              
==========================================
- Hits         7588     7586       -2     
- Misses       2495     2496       +1     
- Partials      484      485       +1
Flag Coverage Δ
unittests 71.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/consoleplugin/config/config.go 75.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 3, 2026
@leandroberetta
Copy link
Contributor

leandroberetta commented Feb 3, 2026

@jpinsonneau I pushed a fix to add the feature field in the json response (frontend-config), hope you don't mind.

@Amoghrd now should work 🤞🏻

@Amoghrd
Copy link
Member

Amoghrd commented Feb 3, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

New images:

  • quay.io/netobserv/network-observability-operator:ba5b495
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-ba5b495
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-ba5b495

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:ba5b495 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-ba5b495

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-ba5b495
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Member

Amoghrd commented Feb 3, 2026

Issue still not fixed @leandroberetta Still see Zone filter

Cluster details:

  • OCP: 4.21.0-0.nightly-2026-02-02-085603
  • NetObserv operator: v0.0.0-sha-ba5b495
  • Loki: 0-click-loki
  • Deployment model: Service
  • Operator image: CREATED_DATE: "2026-02-03T20:03:58.266874367Z", tag: ba5b495
  • eBPF-agent: CREATED_DATE: "2026-02-02T16:23:40.783196578Z", tag: main
  • FLP: CREATED_DATE: "2026-02-01T01:56:43.633214027Z", tag: main
  • ConsolePlugin: CREATED_DATE: "2026-02-03T17:32:23.652136245Z", tag: 4c5a327

@leandroberetta
Copy link
Contributor

leandroberetta commented Feb 3, 2026 •
edited
Loading

Issue still not fixed @leandroberetta Still see Zone filter

Cluster details:

  • OCP: 4.21.0-0.nightly-2026-02-02-085603
  • NetObserv operator: v0.0.0-sha-ba5b495
  • Loki: 0-click-loki
  • Deployment model: Service
  • Operator image: CREATED_DATE: "2026-02-03T20:03:58.266874367Z", tag: ba5b495
  • eBPF-agent: CREATED_DATE: "2026-02-02T16:23:40.783196578Z", tag: main
  • FLP: CREATED_DATE: "2026-02-01T01:56:43.633214027Z", tag: main
  • ConsolePlugin: CREATED_DATE: "2026-02-03T17:32:23.652136245Z", tag: 4c5a327

Yes, sorry about that, a change in the console plugin was missing, now it should work. Tested on my end with these changes. No zone present:

image

OlivierCazade
OlivierCazade approved these changes Feb 4, 2026
View reviewed changes
Copy link
Member

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Feb 4, 2026
@Amoghrd
Copy link
Member

Amoghrd commented Feb 4, 2026

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Feb 4, 2026
@jotak
Copy link
Member

jotak commented Feb 5, 2026

/cherry-pick release-1.11

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2026

@jotak: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak jotak merged commit 0a2cd8f into netobserv:main Feb 5, 2026
15 of 16 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2026

@jpinsonneau: new pull request created: #2424

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

Assignees

@OlivierCazade OlivierCazade

Labels

lgtm needs-review Tells that the PR needs a review ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jpinsonneau @openshift-cherrypick-robot @Amoghrd @leandroberetta @jotak @OlivierCazade