Fix lowercase capture groups

[mjbear]

• Fix lowercase capture groups (should be uppercase per project guidelines)
• In these same (lowercase cap grp) templates only, switch literal whitespace to whitespace regexes

[evilmonkey19]

I suggest adding a test in the templates that check that all the values are in uppercase. It shouldn't be too difficult. Just checking the value will force that the TextFSM templates fails.

[mjbear]

I suggest adding a test in the templates that check that all the values are in uppercase. It shouldn't be too difficult. Just checking the value will force that the TextFSM templates fails.

Good idea.
I'm pulling this to a Draft while I work on test cases. 😀

[evilmonkey19]

Whenever i have some i can add the tests cases, it should extremely easy :) El dj., 30 de gen. 2025, 14:09, Michael Bear ***@***.***> va escriure:

…

I suggest adding a test in the templates that check that all the values are in uppercase. It shouldn't be too difficult. Just checking the value will force that the TextFSM templates fails. Good idea. I'm pulling this to a Draft while I work on test cases. 😀 — Reply to this email directly, view it on GitHub <#1983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANQ2UZWQBFH7BVZPG6G7DUD2NIQADAVCNFSM6AAAAABVO74L2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUGQ3TGMZSHE> . You are receiving this because you commented.Message ID: ***@***.***>

[mjbear]

Whenever i have some i can add the tests cases, it should extremely easy :)

😅
I appreciate the nudge, haha.
I'll own these "lowercase" test cases for the initial development and take your code review suggestions. Sound good? 😁

[evilmonkey19]

Sure! Sorry, i was just trying to help :). I can do then some code review 😜 El dv., 31 de gen. 2025, 2:05, Michael Bear ***@***.***> va escriure:

…

Whenever i have some i can add the tests cases, it should extremely easy :) 😅 I appreciate the nudge, haha. I'll own these "lowercase" test cases for the initial development and take your code review suggestions. Sound good? 😁 — Reply to this email directly, view it on GitHub <#1983 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANQ2UZQ5L4RBAXGTVNZM5JD2NLD4HAVCNFSM6AAAAABVO74L2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRWGA3DANBUGM> . You are receiving this because you commented.Message ID: ***@***.***>

[mjbear]

Sure! Sorry, i was just trying to help :). I can do then some code review 😜

@evilmonkey19
All good!
I really wanted to work on this piece. 🫣
With everything going on in work/life, this motivated me to follow through to create these unit tests.

I made it happen today ... so you'll find a new test case. 🎉 😀

[evilmonkey19]

It looks awesome! I like your trick of the rf I didn't know you could do that 📓. I learn something new today 😄

[mjbear]

It looks awesome! I like your trick of the rf I didn't know you could do that 📓. I learn something new today 😄

😎👍
I've decided I may as well compile the regex as well. It may not result in a performance gain, but I can't really see a reason not to.

[jvanderaa]

@mjbear I absolutely LOVE this and the test set up. I just want to verify, that when the test fails, the system continues to test until all of the files have been looked at right?

[mjbear]

@mjbear I absolutely LOVE this and the test set up. I just want to verify, that when the test fails, the system continues to test until all of the files have been looked at right?

Yes - it continues on with the parsed data checks as well.

I began using this and it failed on IKEv1 and IPv6 (plus a couple of other items) initially until I converted them to uppercase.

Example: https://github.com/networktocode/tree/master/ntc_templates/templates/cisco_asa_show_running-config_all_crypto_map.textfsm
Commit: e60ab59

I checked the GH Actions and apparently I caught the lowercase ones before I pushed the commit to GitHub.

I checked out commit c4e61ad, pulled a copy of the new Python test from commit 324fd65, and re-ran tests to provide output. Note the failed and passed numbers in the summary. 🙂

🎯 Edit: @jvanderaa This is to say that IKEv1 does not pass the new lowercase test case, but continues parsing.

============================================================== short test summary info ===============================================================
FAILED tests/test_capture_group_case.py::test_uppercase_capture_group[./ntc_templates/templates/oneaccess_oneos_show_voice_voice-port_pri_all.textfsm] - AssertionError: assert False
FAILED tests/test_capture_group_case.py::test_uppercase_capture_group[./ntc_templates/templates/cisco_asa_show_running-config_all_crypto_map.textfsm] - AssertionError: assert False
FAILED tests/test_capture_group_case.py::test_uppercase_capture_group[./ntc_templates/templates/cisco_xr_show_lldp_neighbors_detail.textfsm] - AssertionError: assert False
FAILED tests/test_capture_group_case.py::test_uppercase_capture_group[./ntc_templates/templates/cisco_xr_show_processes_cpu.textfsm] - AssertionError: assert False
=============================================== 4 failed, 3324 passed, 18 warnings in 91.60s (0:01:31) ===============================================

I didn't change any capture group names (just case) so this wouldn't be a breaking change, would it?
(Or is it the test case addition?)
My mind wants to know and grow, hehe. 😁 Thank you!