Remove errorStrategy check in getMaxRetries to avoid possible deadloc…

[jorgee]

close #5464

Remove errorStrategy check in getMaxRetries method. It avoids possible deadlock when using task.maxRetries in dynamic errorStrategy directives.

Default maxRetries is set to 1

[netlify]

✅ Deploy Preview for nextflow-docs-staging ready!

Name	Link
🔨 Latest commit	36bca1e
🔍 Latest deploy log	https://app.netlify.com/sites/nextflow-docs-staging/deploys/67321deeb502920008ad5da4
😎 Deploy Preview	https://deploy-preview-5474--nextflow-docs-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pditommaso]

A test is failing here

~ Test 'stub-retry.nf' run failed
   + set -e
   + echo ''
   
   + /home/runner/work/nextflow/nextflow/nextflow -q run ../../stub-retry.nf -stub
   + tee stdout
   ERROR ~ Error executing process > 'stubtest'
   
   Caused by:
     Missing output file(s) `*.txt` expected by process `stubtest`
   
   
   Command executed:
   
     echo "Stubbing. Not creating file"
   
   Command exit status:
     0
   
   Command output:
     Stubbing. Not creating file
   
   Work dir:
     /home/runner/work/nextflow/nextflow/tests/checks/scratch/92/85bf921c434bf3554b86f5eb4fa660
   
   Tip: you can replicate the issue by changing to the process work dir and entering the command `bash .command.run`
   
    -- Check '.nextflow.log' file for details
   ++ grep INFO .nextflow.log
   ++ grep -c 'Submitted process > stubtest'
   + [[ 1 == 1 ]]
   ++ grep INFO .nextflow.log
   ++ grep -c 'Re-submitted process > stubtest'
   + [[ 0 == 1 ]]
   + false

[jorgee]

Yes, It is failing because maxRetries is 0. I need to check why it is returning 0 instead of the default one. I have converted to draft

[jorgee]

A test is failing here

~ Test 'stub-retry.nf' run failed
   + set -e
   + echo ''
   
   + /home/runner/work/nextflow/nextflow/nextflow -q run ../../stub-retry.nf -stub
   + tee stdout
   ERROR ~ Error executing process > 'stubtest'
   
   Caused by:
     Missing output file(s) `*.txt` expected by process `stubtest`
   
   
   Command executed:
   
     echo "Stubbing. Not creating file"
   
   Command exit status:
     0
   
   Command output:
     Stubbing. Not creating file
   
   Work dir:
     /home/runner/work/nextflow/nextflow/tests/checks/scratch/92/85bf921c434bf3554b86f5eb4fa660
   
   Tip: you can replicate the issue by changing to the process work dir and entering the command `bash .command.run`
   
    -- Check '.nextflow.log' file for details
   ++ grep INFO .nextflow.log
   ++ grep -c 'Submitted process > stubtest'
   + [[ 1 == 1 ]]
   ++ grep INFO .nextflow.log
   ++ grep -c 'Re-submitted process > stubtest'
   + [[ 0 == 1 ]]
   + false

Tests are fixed

[pditommaso]

Suggested change

	result != null ? result as int : 1
	result ? result as int : 1

Better to keep as it was before

[jorgee]

I changed because result can be an integer and 0 is considered as false. It was breaking the test when number of retries is set to 0.

[pditommaso]

Why, as a user, should I use 0 retries with a retry error strategy?

[jorgee]

I think it has not too much sense but there was this possibility and it was in the test. Or we keep null check or we change the test.