Repository navigation
create and apply test dataset - #33
Merged
Merged
Conversation
atrigila
reviewed
Jun 18, 2026
atrigila
left a comment
atrigila
left a comment
Contributor
There was a problem hiding this comment.
Left some comments on how to structure the new samplesheet. Do not forget to update the changelog as well.
Compare checksum
atrigila
reviewed
Jun 22, 2026
Contributor
There was a problem hiding this comment.
This one should not be here as your hcanges should only be related to the demux/test full
Contributor
There was a problem hiding this comment.
This one should not be changed as your changes are only related to the test_full
Comment on lines
+20
to
+33
| "multiqc/multiqc_data", | ||
| "multiqc/multiqc_data/llms-full.txt", | ||
| "multiqc/multiqc_data/multiqc.log", | ||
| "multiqc/multiqc_data/multiqc.parquet", | ||
| "multiqc/multiqc_data/multiqc_citations.txt", | ||
| "multiqc/multiqc_data/multiqc_data.json", | ||
| "multiqc/multiqc_data/multiqc_software_versions.txt", | ||
| "multiqc/multiqc_data/multiqc_sources.txt", | ||
| "multiqc/multiqc_report.html", | ||
| "pipeline_info", | ||
| "pipeline_info/nf_core_datasync_software_mqc_versions.yml", | ||
| "shasum", | ||
| "shasum/human_grch38_sequence.sha256", | ||
| "shasum/test_fastq.sha256" |
Contributor
There was a problem hiding this comment.
This doesn't seem to be the content of the demux pipeline, right?
…co/datasync into create_test_dataset
atrigila
approved these changes
Jun 23, 2026
atrigila
left a comment
atrigila
left a comment
Contributor
There was a problem hiding this comment.
Add changelog please before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #23