-
Notifications
You must be signed in to change notification settings - Fork 929
new module: modkit/repair #9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just some minor things :)
|
thanks @famosab for reviewing! I've addressed the comments you gave and all checks are passed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* changed to correct labelling * added modkit/repair * fix test issue * address comments * changed test data dir --------- Co-authored-by: ra25wog <[email protected]> Co-authored-by: Famke Bäuerle <[email protected]>
* changed to correct labelling * added modkit/repair * fix test issue * address comments * changed test data dir --------- Co-authored-by: ra25wog <[email protected]> Co-authored-by: Famke Bäuerle <[email protected]>
PR checklist
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda