Skip to content

Conversation

@jkh00
Copy link
Contributor

@jkh00 jkh00 commented Sep 16, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jkh00 jkh00 added the new module Adding a new module label Sep 16, 2025
@jkh00 jkh00 self-assigned this Sep 16, 2025
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just some minor things :)

@jkh00
Copy link
Contributor Author

jkh00 commented Sep 25, 2025

thanks @famosab for reviewing! I've addressed the comments you gave and all checks are passed :)

Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments :)

Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jkh00 jkh00 added this pull request to the merge queue Sep 29, 2025
Merged via the queue into nf-core:master with commit b5584db Sep 29, 2025
26 checks passed
@jkh00 jkh00 deleted the modkit/repair branch September 29, 2025 08:10
vvvirgy pushed a commit to vvvirgy/modules that referenced this pull request Sep 30, 2025
* changed to correct labelling

* added modkit/repair

* fix test issue

* address comments

* changed test data dir

---------

Co-authored-by: ra25wog <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
chaochaowong pushed a commit to chaochaowong/modules that referenced this pull request Sep 30, 2025
* changed to correct labelling

* added modkit/repair

* fix test issue

* address comments

* changed test data dir

---------

Co-authored-by: ra25wog <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants