Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Don't Block the Event Loop outdated remark about fs.readFile() #7493

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thiagopromano
Copy link

Description

The Don't Block the Event Loop article mentions the fs.readFile() is "currently" not partitioned. This is not the case anymore since v10.

We could either leave the example mentioning that this was the behavior up to v10, as currently implemented in this PR, change it to use fs.read(), or remove this example altogether.

@thiagopromano thiagopromano requested a review from a team as a code owner February 12, 2025 23:51
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 12, 2025 11:52pm

Copy link

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AugustinMauroy AugustinMauroy added content Issues/pr concerning content learn Issues/pr concerning the learn section labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content learn Issues/pr concerning the learn section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants