Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Don't Block the Event Loop outdated remark about fs.readFile() #7493

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

Update Don't Block the Event Loop outdated remark about fs.readFile() #7493

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918232c
Update dont-block-the-event-loop.md
thiagopromano Feb 12, 2025
1e417a6
Update dont-block-the-event-loop.md
thiagopromano Feb 12, 2025
de9e10a
Update dont-block-the-event-loop.md
thiagopromano Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/site/pages/en/learn/asynchronous-work/dont-block-the-event-loop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ Two examples should illustrate the possible variation in task times.

Suppose your server must read files in order to handle some client requests.
After consulting the Node.js [File system](https://nodejs.org/api/fs.html) APIs, you opted to use `fs.readFile()` for simplicity.
However, `fs.readFile()` is ([currently](https://github.com/nodejs/node/pull/17054)) not partitioned: it submits a single `fs.read()` Task spanning the entire file.
However, `fs.readFile()` before v10 was not partitioned: it submitted a single `fs.read()` Task spanning the entire file.
If you read shorter files for some users and longer files for others, `fs.readFile()` may introduce significant variation in Task lengths, to the detriment of Worker Pool throughput.

For a worst-case scenario, suppose an attacker can convince your server to read an _arbitrary_ file (this is a [directory traversal vulnerability](https://www.owasp.org/index.php/Path_Traversal)).
Expand Down
Loading