test2

nokia · Jul 12, 2024 · d427f9f · d427f9f
1 parent 996fc8c
commit d427f9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/moler/util/converterhelper.py b/moler/util/converterhelper.py
@@ -323,7 +323,7 @@ def to_number(self, value, raise_exception: bool = True, none_if_cannot_convert:
                 if raise_exception:
                     raise ex
                 if none_if_cannot_convert:
-                    return None
+                    ret_val = None
         return ret_val
 
     @staticmethod

diff --git a/test/test_helpers.py b/test/test_helpers.py
@@ -67,6 +67,9 @@ def test_converterhelper_number_wrong_format():
         converter.to_number(value="abc", raise_exception=True)
     val = converter.to_number(value="abc", raise_exception=False)
     assert val == 0
+    val2 = converter.to_number(value="abc", raise_exception=False,
+                               none_if_cannot_convert=True)
+    assert val2 is None
 
 
 def test_converterhelper_number():