feat: Appointment max delay config#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: novosga/novosga#479
This pull request removes the logic that enforced a maximum allowed delay for scheduling appointments and also removes the related expired schedule error message from all translation files. The main effect is that the system no longer checks or blocks the distribution of expired scheduled appointments based on a time limit.
Key changes:
Removal of scheduling delay logic:
DefaultController.phpthat enforced a maximum allowed delay (MAX_SCHEDULING_MINUTES_DELAY) for distributing scheduled appointments, along with the related constant and dependency onClockInterface. [1] [2] [3]Translation cleanup:
error.schedule.expiredtranslation key and its translations from all translation files:NovosgaTriageBundle.en.xlf,NovosgaTriageBundle.en_US.xlf,NovosgaTriageBundle.es.xlf,NovosgaTriageBundle.es_AR.xlf,NovosgaTriageBundle.pt_BR.xlf, andNovosgaTriageBundle.pt_PT.xlf. [1] [2] [3] [4] [5] [6]