Skip to content

feat: Appointment max delay config #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogeriolino merged 1 commit into from
May 1, 2026
Merged

feat: Appointment max delay config #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/Controller/DefaultController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

namespace Novosga\TriageBundle\Controller;

use DateTime;
use Exception;
use Novosga\Entity\UsuarioInterface;
use Novosga\Http\Envelope;
Expand Down Expand Up @@ -45,8 +44,6 @@
#[Route("/", name: "novosga_triage_")]
class DefaultController extends AbstractController
{
private const MAX_SCHEDULING_MINUTES_DELAY = 60;

#[Route("/", name: "index", methods: ['GET'])]
public function index(
ServicoServiceInterface $servicoService,
Expand Down Expand Up @@ -223,7 +220,6 @@ public function distribuiSenhaAgendamento(
AgendamentoServiceInterface $agendamentoService,
PrioridadeRepositoryInterface $prioridadeRepository,
TranslatorInterface $translator,
ClockInterface $clock,
int $id,
): Response {
$agendamento = $agendamentoService->getById($id);
Expand All @@ -234,24 +230,6 @@ public function distribuiSenhaAgendamento(
throw new Exception($translator->trans('error.schedule.confirmed', [], NovosgaTriageBundle::getDomain()));
}

$timezone = $agendamento->getUnidade()->getDateTimeZone();
$data = $agendamento->getData()->format('Y-m-d');
$hora = $agendamento->getHora()->format('H:i');
$dt = DateTime::createFromFormat('Y-m-d H:i', "{$data} {$hora}", $timezone);
$now = $clock->now()->setTimezone($timezone);

if ($dt < $now) {
$diff = $now->diff($dt);
$mins = $diff->i + ($diff->h * 60);
if ($mins > self::MAX_SCHEDULING_MINUTES_DELAY) {
throw new Exception($translator->trans(
'error.schedule.expired',
[ '%min%' => self::MAX_SCHEDULING_MINUTES_DELAY ],
NovosgaTriageBundle::getDomain()
));
}
}

/** @var UsuarioInterface */
$usuario = $this->getUser();
$unidade = $agendamento->getUnidade();
Expand Down
98 changes: 47 additions & 51 deletions src/Resources/translations/NovosgaTriageBundle.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,239 +14,235 @@
<trans-unit id="1">
<source>title</source>
<target>Screening</target>

</trans-unit>
<trans-unit id="2">
<source>subtitle</source>
<target>Tickets issue</target>

</trans-unit>
<trans-unit id="3">
<source>button.find</source>
<target>Search</target>

</trans-unit>
<trans-unit id="4">
<source>placeholder.search</source>
<target>Ticket search</target>

</trans-unit>
<trans-unit id="5">
<source>label.no_priority</source>
<target>Normal</target>

</trans-unit>
<trans-unit id="6">
<source>label.priority</source>
<target>Priority</target>

</trans-unit>
<trans-unit id="7">
<source>label.total</source>
<target>Total</target>

</trans-unit>
<trans-unit id="8">
<source>modal.attendance</source>
<target>Attending</target>

</trans-unit>
<trans-unit id="9">
<source>modal.attendance.ticket</source>
<target>Ticket</target>

</trans-unit>
<trans-unit id="10">
<source>label.service</source>
<target>Service</target>

</trans-unit>
<trans-unit id="11">
<source>label.ticket.wait_time</source>
<target>Waiting time</target>

</trans-unit>
<trans-unit id="12">
<source>label.customer</source>
<target>Customer</target>

</trans-unit>
<trans-unit id="13">
<source>label.customer.name</source>
<target>Name</target>

</trans-unit>
<trans-unit id="14">
<source>label.customer.id</source>
<target>Name</target>

</trans-unit>
<trans-unit id="15">
<source>label.yes</source>
<target>Yes</target>

</trans-unit>
<trans-unit id="16">
<source>label.no</source>
<target>No</target>

</trans-unit>
<trans-unit id="17">
<source>alert.title</source>
<target>Alert</target>

</trans-unit>
<trans-unit id="18">
<source>alert.cancel.text</source>
<target>Do you really wish to cancel that ticket?</target>

</trans-unit>
<trans-unit id="19">
<source>alert.reactivate.text</source>
<target>Do you really wish to reactivate that ticket?</target>

</trans-unit>
<trans-unit id="20">
<source>alert.transfer.text</source>
<target>Do you really want to transfer this ticket?</target>

</trans-unit>
<trans-unit id="21">
<source>modal.attendance.button.reactivate</source>
<target>Reactivate ticket</target>

</trans-unit>
<trans-unit id="22">
<source>modal.attendance.button.transfer</source>
<target>Transfer / change ticket</target>

</trans-unit>
<trans-unit id="23">
<source>modal.attendance.button.cancel</source>
<target>Cancel ticket</target>

</trans-unit>
<trans-unit id="24">
<source>modal.transfer</source>
<target>Transfer ticket</target>

</trans-unit>
<trans-unit id="25">
<source>modal.transfer.button</source>
<target>Transfer</target>

</trans-unit>
<trans-unit id="35">
<source>modal.search</source>
<target>Search</target>

</trans-unit>
<trans-unit id="36">
<source>modal.search.placeholder</source>
<target>Full ticket code, chars or number</target>

</trans-unit>
<trans-unit id="37">
<source>label.ticket.number</source>
<target>Number</target>

</trans-unit>
<trans-unit id="38">
<source>label.ticket.arrival_date</source>
<target>Date of arrival</target>

</trans-unit>
<trans-unit id="39">
<source>label.ticket.start_date</source>
<target>Start date</target>

</trans-unit>
<trans-unit id="40">
<source>label.ticket.end_date</source>
<target>End date</target>

</trans-unit>
<trans-unit id="41">
<source>label.triage</source>
<target>Screening</target>

</trans-unit>
<trans-unit id="42">
<source>label.ticket.user</source>
<target>Attendant</target>

</trans-unit>
<trans-unit id="43">
<source>label.status</source>
<target>Status</target>

</trans-unit>
<trans-unit id="44">
<source>MM/DD/YYYY HH:mm:ss</source>
<target>MM/DD/YYYY HH:mm:ss</target>

</trans-unit>
<trans-unit id="45">
<source>MM/DD/YYYY</source>

</trans-unit>
<trans-unit id="49">
<source>modal.search.button.submit</source>
<target>Search</target>

</trans-unit>
<trans-unit id="50">
<source>server.datetime</source>
<target>Server datetime</target>

</trans-unit>
<trans-unit id="51">
<source>error.invalid_service</source>
<target>Invalid service</target>

</trans-unit>
<trans-unit id="52">
<source>error.schedule.confirmed</source>

</trans-unit>
<trans-unit id="53">
<source>error.schedule.expired</source>


</trans-unit>
<trans-unit id="54">
<source>label.name</source>
<target>Name</target>

</trans-unit>
<trans-unit id="55">
<source>label.priority</source>
<target>Priority</target>

</trans-unit>
<trans-unit id="56">
<source>label.ticket</source>
<target>Ticket</target>

</trans-unit>
<trans-unit id="57">
<source>label.customer.id</source>
<target>Document</target>

</trans-unit>
<trans-unit id="58">
<source>label.description</source>
<target>Description</target>

</trans-unit>
<trans-unit id="59">
<source>label.subservices</source>
<target>Subservices </target>

</trans-unit>
<trans-unit id="60">
<source>label.date</source>
<target>Date</target>

</trans-unit>
<trans-unit id="61">
<source>label.time</source>
Expand Down
Loading
Loading