Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imputer fill_value #125

Closed
wants to merge 5 commits into from
Closed

Imputer fill_value #125

wants to merge 5 commits into from

Conversation

vitorsrg
Copy link
Contributor

Status

READY

Todo list

Description of the changes proposed in the pull request

  • add fill_value to imputer
  • add to .gitignore some files created by the tests

Sorry, something went wrong.

@vitorsrg vitorsrg requested a review from a team as a code owner February 12, 2020 02:23
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@04f361a). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage          ?   94.72%           
=========================================
  Files             ?       25           
  Lines             ?     1592           
  Branches          ?      223           
=========================================
  Hits              ?     1508           
  Misses            ?       49           
  Partials          ?       35
Impacted Files Coverage Δ
src/fklearn/training/imputation.py 94.73% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f361a...e6f1d18. Read the comment docs.

Copy link
Contributor

@gppeixoto gppeixoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitor, do you mind transferring this PR to a fork? take a look at our contributing guide to see the feature branching process

@vitorsrg vitorsrg mentioned this pull request Feb 12, 2020
3 tasks
@vitorsrg vitorsrg closed this Feb 12, 2020
@vitorsrg vitorsrg deleted the feature/imputer-fill-value branch February 12, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants