-
-
Notifications
You must be signed in to change notification settings - Fork 9
NaN tests + Workflow + README fixes #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is critical that NaN != NaN returns True, as testing for NaNs is often defined by this check. Since sleef comparison doesn't return True for NaN != NaN yet, this should be fixed in the sleef wrapper. |
Yes for now this won't be an issue as, there is an API |
I've opened #115 to fix the NaN comparisons and add extra tests for them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think two of the changes to the readme should be reverted
Just noticed window's build time is increased to 10 minutes but this seems to work |
Thanks @SwayamInSync! |
This PR contributes as follows:
nan != nan
should return true) hence removing that particular test