Skip to content

Test and fix comparisons with NaNs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 4, 2025
Merged

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Jul 4, 2025

Inspired by #114

@SwayamInSync
Copy link
Collaborator

Thanks @juntyr this PR makes sense to me

  • NaN != NaN => true
  • min/max ops propogate NaN if any input is NaN

@ngoldbaum
Copy link
Member

@SwayamInSync it looks like maybe there's a caching issue in the CI configuration? On windows this PR is failing with:

CMake Error at build/src/libm/cmake_install.cmake:51 (file):
  file INSTALL cannot find
  "D:/a/numpy-user-dtypes/numpy-user-dtypes/sleef/build/bin/sleef.dll": File
  exists.
Call Stack (most recent call first):
  build/src/cmake_install.cmake:37 (include)
  build/cmake_install.cmake:37 (include)

@SwayamInSync
Copy link
Collaborator

From logs it seem building from cmake using --parallel causing this race condition. I'll debug this and push a fix

@SwayamInSync
Copy link
Collaborator

@ngoldbaum windows CI build fix was pushed in #114

@ngoldbaum
Copy link
Member

@juntyr can you rebase please?

@ngoldbaum
Copy link
Member

Thanks @juntyr!

@ngoldbaum ngoldbaum merged commit 5914811 into numpy:main Jul 4, 2025
6 checks passed
@juntyr juntyr deleted the nan-comparisons branch July 4, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants