Repository navigation
fix(simulator): build on macOS - #198
Open
subinita01 wants to merge 2 commits into
Open
subinita01 wants to merge 2 commits into
subinita01 wants to merge 2 commits into
Conversation
subinita01
force-pushed
the
fix/simulator-macos-build
branch
from
October 14, 2026 06:06
e596304 to
bec159a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the simulator on macOS (Homebrew).
find_package(SDL2)already ran, but its include and library variables weren't used, so Homebrew's SDL2 headers and library were never found.explicit_bzero, which macOS libc lacks. Apple builds now usememset_s, which libwally already supports as a non-elidable wipe. On RISC-V (firmware) and Linux the effectiveconfig.his unchanged.Tested on macOS (Apple clang): clean simulator build with no extra flags,
ctestpasses, and the host tests' libwally now builds there too. Not tested on Linux.