Skip to content

fix(simulator): build on macOS #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subinita01 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −3
Open

fix(simulator): build on macOS #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b68874
fix(simulator): find SDL2 through its CMake package variables
subinita01 Oct 14, 2026
bec159a
fix(wally): wipe with memset_s on macOS, which lacks explicit_bzero
subinita01 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/libwally-core/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
/* #undef HAVE_DLFCN_H */

/* Define to 1 if you have the `explicit_bzero' function. */
#ifndef __APPLE__
#define HAVE_EXPLICIT_BZERO 1
#endif

/* Define to 1 if you have the `explicit_memset' function. */
/* #undef HAVE_EXPLICIT_MEMSET */
Expand All @@ -35,7 +37,10 @@
#define HAVE_MEMORY_H 1

/* Define to 1 if you have the `memset_s' function. */
/* #undef HAVE_MEMSET_S */
/* macOS has no explicit_bzero; memset_s is its non-elidable wipe. */
#ifdef __APPLE__
#define HAVE_MEMSET_S 1
#endif

/* Define if we have mmap */
/* #undef HAVE_MMAP */
Expand Down
9 changes: 7 additions & 2 deletions simulator/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@ set_target_properties(lvgl PROPERTIES POSITION_INDEPENDENT_CODE ON)
target_include_directories(lvgl PUBLIC
${LVGL_DIR}
${LVGL_DIR}/src
# Debian's libsdl2-dev drops headers straight under /usr/include (already
# a default search path), but Homebrew's puts them under a non-default
# prefix; SDL2_INCLUDE_DIRS covers both without changing the Linux path.
${SDL2_INCLUDE_DIRS}
)
target_include_directories(lvgl PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}
Expand All @@ -376,7 +380,7 @@ target_compile_definitions(lvgl PRIVATE
lv_refr_now=kern_lv_refr_now_real
)
target_link_libraries(lvgl PUBLIC
SDL2
${SDL2_LIBRARIES}
)

add_executable(kern_simulator
Expand Down Expand Up @@ -418,6 +422,7 @@ target_include_directories(kern_simulator PRIVATE
# LVGL
${LVGL_DIR}
${LVGL_DIR}/src
${SDL2_INCLUDE_DIRS}
)

target_compile_definitions(kern_simulator PRIVATE
Expand Down Expand Up @@ -472,7 +477,7 @@ endif()

target_link_libraries(kern_simulator PRIVATE
lvgl
SDL2
${SDL2_LIBRARIES}
Threads::Threads
m
wally
Expand Down
Loading