-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homogeneous nucleation of liquid droplets & expansion chamber example #1492
Draft
claresinger
wants to merge
64
commits into
open-atmos:main
Choose a base branch
from
claresinger:expansion_chamber
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mimic the princeton expansion chamber
… match Fig 4 in the manuscript
…some entries currently failing.
… archive.org); mention both urls in the code
slayoo
reviewed
Jan 9, 2025
slayoo
reviewed
Jan 9, 2025
slayoo
reviewed
Jan 9, 2025
55e53f0
to
3b607ca
Compare
claresinger
commented
Jan 13, 2025
…() and use it in HomogeneousLiquidNucleation() ... but still fails
…too large to convert to C long")
…flow. and increasing null SDs to avoid running out of SDs. add some new products to track nucleated particles better.
…le count. seems like Nd is working. need to write an actual test for it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
========================================
Coverage 85.24% 85.24%
========================================
Files 379 389 +10
Lines 9297 9436 +139
========================================
+ Hits 7925 8044 +119
- Misses 1372 1392 +20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/pasting the notes @slayoo added from our conversation with @AgnieszkaZaba this morning.
ExpansionChamber
environment (featuring perfect gas expansion, but not featuring hydrostatics) instead of usingParcel
would help in making the code readableadiabatic_exponent
formulaeSuperParticleSpawningDynamic
base-class could be best to derive from two dynamics:Seeding
andHomogeneousLiquidNucleation
SeedingMethods
to sharedSpawningMethods
The expansion chamber example is aimed to mimic the laboratory experiments described here: https://arxiv.org/abs/2501.01467