Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homogeneous nucleation of liquid droplets & expansion chamber example #1492

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from

Conversation

claresinger
Copy link
Collaborator

@claresinger claresinger commented Jan 7, 2025

Copy/pasting the notes @slayoo added from our conversation with @AgnieszkaZaba this morning.

  • the laboratory paper uses a Normal distribution rather than Lognormal - perhaps worth adding to PySDM
  • a new ExpansionChamber environment (featuring perfect gas expansion, but not featuring hydrostatics) instead of using Parcel would help in making the code readable
  • new adiabatic_exponent formulae
  • a SuperParticleSpawningDynamic base-class could be best to derive from two dynamics: Seeding and HomogeneousLiquidNucleation
  • rename SeedingMethods to shared SpawningMethods
  • could we construct a simple adaptive substepping logic by comparing the nucleation rate and the timestep?
  • test idea: J_homogeneous table from S&P
  • test idea: long vs. short timestep
  • test idea: S_max for short vs. long timestep
  • test idea: conservation of total water
  • test idea: check droplet number matches expectation from multiplicity of nucleated SDs

The expansion chamber example is aimed to mimic the laboratory experiments described here: https://arxiv.org/abs/2501.01467

claresinger and others added 27 commits January 30, 2025 17:05
…() and use it in HomogeneousLiquidNucleation() ... but still fails
…flow. and increasing null SDs to avoid running out of SDs. add some new products to track nucleated particles better.
…le count. seems like Nd is working. need to write an actual test for it.
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 88.30409% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (17cf24a) to head (7150f84).

Files with missing lines Patch % Lines
PySDM/environments/expansion_chamber.py 68.18% 14 Missing ⚠️
PySDM/environments/impl/moist_lagrangian.py 88.88% 2 Missing ⚠️
.../physics/adiabatic_exponent/moist_leading_terms.py 66.66% 2 Missing ⚠️
PySDM/dynamics/homogeneous_liquid_nucleation.py 96.42% 1 Missing ⚠️
PySDM/physics/adiabatic_exponent/dry.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1492    +/-   ##
========================================
  Coverage   85.24%   85.24%            
========================================
  Files         379      389    +10     
  Lines        9297     9436   +139     
========================================
+ Hits         7925     8044   +119     
- Misses       1372     1392    +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants