Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homogeneous nucleation of liquid droplets & expansion chamber example #1492

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
ca90206
add example of lifting parcel for time t_lift and then holding it to …
Nov 27, 2024
f716859
do dp sweep to plot Tmin vs dp under a few conditions of S0 and C0 to…
Dec 19, 2024
f41866b
Merge remote-tracking branch 'oa/main' into expansion_chamber
Dec 20, 2024
82aca13
Merge remote-tracking branch 'oa/main' into expansion_chamber
Jan 6, 2025
58f5e14
add some placeholders for S&P classic nucleation theory homogeneous n…
Jan 7, 2025
5f4dc31
add formulae for critical size of nucleated droplets
Jan 7, 2025
5d1be16
doc eq origin
Jan 7, 2025
d0b56aa
pylint
Jan 7, 2025
c98eaab
add unit tests for formulae relative to tables 11.1 and 11.4 in S&P. …
Jan 7, 2025
099e7ca
add bibliography entries. I'm not sure I did this correctly.
Jan 7, 2025
b141f02
Merge remote-tracking branch 'oa/main' into expansion_chamber
Jan 7, 2025
37053f8
swtich url for S&P from 3rd to 2nd ed. (linked full text available on…
slayoo Jan 7, 2025
ca940e8
accommodate S&P url in doc-generating script
slayoo Jan 7, 2025
70e0548
address pylint hints
slayoo Jan 7, 2025
a501b8f
addressing devops_tests hints - header cells in the notebook
slayoo Jan 7, 2025
e09bdc4
whitespace removal
slayoo Jan 7, 2025
5c3df34
remove null
Jan 10, 2025
4135c22
better variable names
Jan 10, 2025
3b607ca
use Gaussian aerosol mode, not LogNormal
Jan 10, 2025
f6f26bb
change import order
slayoo Jan 10, 2025
e59f1af
Merge remote-tracking branch 'oa/main' into expansion_chamber
Jan 13, 2025
33e2e3a
add expansion_chamber environment. todo check the thermodynamics here…
Jan 13, 2025
b584cfd
Merge remote-tracking branch 'oa/main' into expansion_chamber
Jan 15, 2025
03bffe7
refactor ExpansionChamber env and use it in Erinin_et_al_2025 example
slayoo Jan 26, 2025
ce6e454
forgotten __init__ move
slayoo Jan 26, 2025
220b13e
Merge branch 'main' into expansion_chamber
slayoo Jan 26, 2025
b91a94c
replace assumed temperature profile with adiabatic temperature condit…
Jan 29, 2025
a7f4950
add new physics formulae for adiabatic exponent
Jan 29, 2025
4ffd684
introduce homogeneous nucleation dynamic with some common code with s…
slayoo Jan 30, 2025
cd3375b
raname seeding -> spawning in backend tests
slayoo Jan 30, 2025
f9d99ce
raname injecting -> spawning in backend tests
slayoo Jan 30, 2025
8bc50bb
comment on zero multiplicity -> MC sampling?
slayoo Jan 30, 2025
e5abcb3
work in progress towards getting nucleation dynamic enabled in the ex…
slayoo Jan 30, 2025
fedd946
add back boltzmann constant
Jan 30, 2025
fe4bfb9
fix errors in dynamic to get to error with 'No available null SDs to …
Jan 30, 2025
59a0fa4
wip add nan SDs. getting error about index out of bounds.
Jan 30, 2025
3bb377b
make attribute saving logic compatible with variable state-vector size
slayoo Jan 31, 2025
c4f2ec8
introduce SuperParticleSpawningDynamic.check_extensive_attribute_keys…
slayoo Feb 3, 2025
763d853
make multiplicity a Storage as well (currently stops on: "Python int …
slayoo Feb 4, 2025
1dc09c9
make example run with nucleation by shortening timestep to avoid over…
Feb 4, 2025
d53312a
simplified units handling, enabled condensation adaptivity
slayoo Feb 6, 2025
c11118c
resolve merge conflict
slayoo Feb 6, 2025
0ee157d
fix bib issues
slayoo Feb 6, 2025
ee6cca2
fix multiplicity product. print out fractional change in total partic…
Feb 7, 2025
decce8e
Merge remote-tracking branch 'oa/main' into expansion_chamber
Feb 11, 2025
deb27c4
qv to vapour_mixing_ratio spelled out
Feb 11, 2025
60cb166
fixing tests, addressing pylint hints
slayoo Feb 13, 2025
8989e38
reinstantiate changes from #1509
slayoo Feb 13, 2025
84759aa
addressing pylint hints
slayoo Feb 13, 2025
fe370f8
setup chamber smoke tests execution on CI
slayoo Feb 13, 2025
2b811bd
address pylint hints
slayoo Feb 13, 2025
2bd28ba
fix badge URLs
slayoo Feb 13, 2025
2896faa
add TODO labels (pointing to the PR!_
slayoo Feb 13, 2025
dc1217e
pylint hints, notebook header
slayoo Feb 13, 2025
ab4412d
pylint hints
slayoo Feb 13, 2025
43c4828
missing bib entry
slayoo Feb 13, 2025
897fb3e
simplify notebook code; skip nucleation if RH<1
slayoo Feb 13, 2025
1e7631e
address pylint hints
slayoo Feb 13, 2025
7d180ad
address pylint hints again
slayoo Feb 13, 2025
649caba
fix MockParticulator
slayoo Feb 13, 2025
89d1086
extensions in homogeneous liquid nucleation unit tests
slayoo Feb 14, 2025
12b55dd
less crazy test values for T and S
slayoo Feb 14, 2025
7150f84
unit test for homogeneous nucleation dynamic using constant rate
slayoo Feb 14, 2025
ed24039
Merge remote-tracking branch 'oa/main' into expansion_chamber
Feb 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve merge conflict
slayoo committed Feb 6, 2025
commit c11118c5fd8bce6e7f0c02b2539a5fa58791d87a
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ default_stages: [commit]

repos:
- repo: https://github.com/psf/black
rev: 24.1.0
rev: 25.1.0
hooks:
- id: black

@@ -14,7 +14,7 @@ repos:
# - id: isort

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
rev: v5.0.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
2 changes: 1 addition & 1 deletion PySDM/attributes/impl/attribute_registry.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" definition of decorator used to register PySDM attribute classes """
"""definition of decorator used to register PySDM attribute classes"""

import warnings

4 changes: 2 additions & 2 deletions PySDM/attributes/impl/dummy_attribute.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" logic around `PySDM.attributes.impl.dummy_attribute.DummyAttribute` - parent class
for do-nothing attributes """
"""logic around `PySDM.attributes.impl.dummy_attribute.DummyAttribute` - parent class
for do-nothing attributes"""

import numpy as np

2 changes: 1 addition & 1 deletion PySDM/backends/impl_common/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" common code for all backends """
"""common code for all backends"""
2 changes: 1 addition & 1 deletion PySDM/backends/impl_numba/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" the guts of the CPU backend """
"""the guts of the CPU backend"""
2 changes: 1 addition & 1 deletion PySDM/backends/impl_numba/methods/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" method classes of the CPU backend """
"""method classes of the CPU backend"""

from .chemistry_methods import ChemistryMethods
from .collisions_methods import CollisionsMethods
2 changes: 1 addition & 1 deletion PySDM/backends/impl_numba/methods/spawning_methods.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" CPU implementation of backend methods for particle spawning """
"""CPU implementation of backend methods for particle spawning"""

from functools import cached_property

2 changes: 1 addition & 1 deletion PySDM/backends/impl_numba/test_helpers/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" logic intended to be used in tests only including the SciPy-based condensation solver """
"""logic intended to be used in tests only including the SciPy-based condensation solver"""
2 changes: 1 addition & 1 deletion PySDM/backends/impl_thrust_rtc/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" the guts of the GPU backend """
"""the guts of the GPU backend"""
2 changes: 1 addition & 1 deletion PySDM/backends/impl_thrust_rtc/methods/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" method classes of the GPU backend """
"""method classes of the GPU backend"""
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" constant value """
"""constant value"""


class ConstEc:
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" common code for implementing collision kernels """
"""common code for implementing collision kernels"""
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" common parent class for gravitational collision kernels """
"""common parent class for gravitational collision kernels"""


class Gravitational: # pylint: disable=too-few-public-methods
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" common parent class for collision kernels specified using Berry's parameterization """
"""common parent class for collision kernels specified using Berry's parameterization"""

from PySDM.physics import constants as const

2 changes: 1 addition & 1 deletion PySDM/dynamics/impl/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" stuff not intended to be imported from user code """
"""stuff not intended to be imported from user code"""

from .register_dynamic import register_dynamic
from .super_particle_spawning_dynamic import SuperParticleSpawningDynamic
4 changes: 2 additions & 2 deletions PySDM/dynamics/impl/register_dynamic.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" decorator for dynamics classes
ensuring that their instances can be re-used with multiple builders """
"""decorator for dynamics classes
ensuring that their instances can be re-used with multiple builders"""

from copy import deepcopy

4 changes: 2 additions & 2 deletions PySDM/dynamics/seeding.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
""" particle injection handling, requires initalising a simulation with
"""particle injection handling, requires initalising a simulation with
enough particles flagged with NaN multiplicity (translated to zeros
at multiplicity discretisation """
at multiplicity discretisation"""

from collections.abc import Sized

2 changes: 1 addition & 1 deletion PySDM/environments/impl/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
""" common internals not intended to be imported from user code """
"""common internals not intended to be imported from user code"""

from PySDM.environments.impl.register_environment import register_environment
4 changes: 2 additions & 2 deletions PySDM/environments/impl/register_environment.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" decorator for environment classes
ensuring that their instances can be re-used with multiple builders """
"""decorator for environment classes
ensuring that their instances can be re-used with multiple builders"""

from copy import deepcopy

4 changes: 2 additions & 2 deletions PySDM/exporters/netcdf_exporter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" netCDF exporter implemented using
[SciPy.io.netcdf_file](https://docs.scipy.org/doc/scipy/reference/tutorial/io.html#netcdf)
"""netCDF exporter implemented using
[SciPy.io.netcdf_file](https://docs.scipy.org/doc/scipy/reference/tutorial/io.html#netcdf)
"""

import numpy as np
2 changes: 1 addition & 1 deletion PySDM/impl/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" stuff not intended to be used from user code """
"""stuff not intended to be used from user code"""
4 changes: 2 additions & 2 deletions PySDM/initialisation/impl/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
""" commons (incl. `PySDM.initialisation.impl.spectrum.Spectrum` base class)
not intended to be imported from user code """
"""commons (incl. `PySDM.initialisation.impl.spectrum.Spectrum` base class)
not intended to be imported from user code"""
2 changes: 1 addition & 1 deletion PySDM/initialisation/sampling/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
""" particle attribute sampling logic """
"""particle attribute sampling logic"""
2 changes: 1 addition & 1 deletion PySDM/physics/air_dynamic_viscosity/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
""" air dynamic viscosity formulae """
"""air dynamic viscosity formulae"""

from .zografos_et_al_1987 import ZografosEtAl1987
2 changes: 1 addition & 1 deletion PySDM/physics/bulk_phase_partitioning/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" phase partitioning formulae for bulk description of cloud water """
"""phase partitioning formulae for bulk description of cloud water"""

from PySDM.impl.null_physics_class import Null
from .kaul_et_al_2015 import KaulEtAl2015
8 changes: 4 additions & 4 deletions PySDM/physics/impl/fake_unit_registry.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
""" logic around `PySDM.physics.impl.fake_unit_registry.FakeUnitRegistry` - PySDM mock of Pint's
[UnitRegistry](https://pint.readthedocs.io/en/stable/developers_reference.html#pint.UnitRegistry),
with the genuine Pint class used only within unit tests through the
`PySDM.physics.dimensional_analysis.DimensionalAnalysis` context manager
"""logic around `PySDM.physics.impl.fake_unit_registry.FakeUnitRegistry` - PySDM mock of Pint's
[UnitRegistry](https://pint.readthedocs.io/en/stable/developers_reference.html#pint.UnitRegistry),
with the genuine Pint class used only within unit tests through the
`PySDM.physics.dimensional_analysis.DimensionalAnalysis` context manager
"""


6 changes: 3 additions & 3 deletions PySDM/physics/impl/flag.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
""" flag disabling `PySDM.physics.impl.fake_unit_registry.FakeUnitRegistry` within
`PySDM.physics.dimensional_analysis.DimensionalAnalysis`
context manager
"""flag disabling `PySDM.physics.impl.fake_unit_registry.FakeUnitRegistry` within
`PySDM.physics.dimensional_analysis.DimensionalAnalysis`
context manager
"""

DIMENSIONAL_ANALYSIS = False
2 changes: 1 addition & 1 deletion PySDM/physics/isotope_diffusivity_ratios/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" heavy-to-light diffusivity ratios for water molecules """
"""heavy-to-light diffusivity ratios for water molecules"""

from PySDM.impl.null_physics_class import Null
from .grahams_law import GrahamsLaw
4 changes: 2 additions & 2 deletions PySDM/physics/isotope_diffusivity_ratios/grahams_law.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" [Graham's law](https://en.wikipedia.org/wiki/Graham%27s_law)
see also eq. (21) in [Horita et al. 2008](https://doi.org/10.1080/10256010801887174)
"""[Graham's law](https://en.wikipedia.org/wiki/Graham%27s_law)
see also eq. (21) in [Horita et al. 2008](https://doi.org/10.1080/10256010801887174)
"""


Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" factors describing partitioning of water isotopologues under thermodynamic
phase equilibrium, defined as ratios alpha of isotopic ratios R """
"""factors describing partitioning of water isotopologues under thermodynamic
phase equilibrium, defined as ratios alpha of isotopic ratios R"""

from PySDM.impl.null_physics_class import Null
from .barkan_and_luz_2005 import BarkanAndLuz2005
2 changes: 1 addition & 1 deletion PySDM/physics/isotope_meteoric_water_line/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" definitions of meteoric water line parameters
"""definitions of meteoric water line parameters
and definitions of the excess quantities"""

from PySDM.impl.null_physics_class import Null
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
""" based on [Picciotto et al. 1960](https://doi.org/10.1038/187857a0)
where delta(2H)= slope_coeff * delta(18O) + intercept_coeff formulae is given
with swapped 2H and 18O in a paper
"""
"""based on [Picciotto et al. 1960](https://doi.org/10.1038/187857a0)
where delta(2H)= slope_coeff * delta(18O) + intercept_coeff formulae is given
with swapped 2H and 18O in a paper
"""


class PicciottoEtAl1960: # pylint: disable=too-few-public-methods
2 changes: 1 addition & 1 deletion PySDM/physics/isotope_ratio_evolution/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" isotope-ratio evolution formulae (incl. Rayleigh distillation) """
"""isotope-ratio evolution formulae (incl. Rayleigh distillation)"""

from PySDM.impl.null_physics_class import Null
from .merlivat_and_jouzel_1979 import MerlivatAndJouzel1979
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" Fractional distillation assuming continuous removal under equilibrium """
"""Fractional distillation assuming continuous removal under equilibrium"""


class RayleighDistillation: # pylint:disable=too-few-public-methods
4 changes: 2 additions & 2 deletions PySDM/physics/isotope_relaxation_timescale/bolin_1958.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" Timescale derived for tritium with assumption of zero ambient concentration - see text above
Table 1 [Bolin 1958](https://digitallibrary.un.org/record/3892725) """
"""Timescale derived for tritium with assumption of zero ambient concentration - see text above
Table 1 [Bolin 1958](https://digitallibrary.un.org/record/3892725)"""

import numpy as np

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" eq. 28 in [Miyake et al. 1968](https://doi.org/10.2467/mripapers1950.19.2_243) """
"""eq. 28 in [Miyake et al. 1968](https://doi.org/10.2467/mripapers1950.19.2_243)"""


class MiyakeEtAl1968: # pylint: disable=too-few-public-methods
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" based on [Picciotto et al. 1960](https://doi.org/10.1038/187857a0)
where delta(T)=-(a*T + b) formulae given, here cast as T(delta)=(-delta-b)/a """
"""based on [Picciotto et al. 1960](https://doi.org/10.1038/187857a0)
where delta(T)=-(a*T + b) formulae given, here cast as T(delta)=(-delta-b)/a"""


class PicciottoEtAl1960: # pylint: disable=too-few-public-methods
2 changes: 1 addition & 1 deletion PySDM/physics/terminal_velocity/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" terminal velocity formulae """
"""terminal velocity formulae"""

from .rogers_yau import RogersYau
from .gunn_kinzer_1949 import GunnKinzer1949
2 changes: 1 addition & 1 deletion PySDM/physics/terminal_velocity/gunn_kinzer_1949.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" [Gunn & Kinzer 1949](https://doi.org/10.1175/1520-0469(1949)006%3C0243:TTVOFF%3E2.0.CO;2) """
"""[Gunn & Kinzer 1949](https://doi.org/10.1175/1520-0469(1949)006%3C0243:TTVOFF%3E2.0.CO;2)"""


class GunnKinzer1949: # pylint: disable=too-few-public-methods
2 changes: 1 addition & 1 deletion PySDM/physics/terminal_velocity/power_series.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" power-series formulation """
"""power-series formulation"""


class PowerSeries: # pylint: disable=too-few-public-methods
2 changes: 1 addition & 1 deletion PySDM/products/impl/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" commons, not intended to be imported from user code """
"""commons, not intended to be imported from user code"""

from PySDM.products.impl.moist_environment_product import MoistEnvironmentProduct
from PySDM.products.impl.moment_product import MomentProduct
2 changes: 1 addition & 1 deletion PySDM/products/impl/moment_product.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" common code for products computing statistical moments (e.g., effective radius, acidity) """
"""common code for products computing statistical moments (e.g., effective radius, acidity)"""

from abc import ABC

4 changes: 2 additions & 2 deletions PySDM/products/impl/register_product.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" decorator for product classes
ensuring that their instances can be re-used with multiple builders """
"""decorator for product classes
ensuring that their instances can be re-used with multiple builders"""

from copy import deepcopy

2 changes: 1 addition & 1 deletion PySDM/products/optical/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" cloud optical properties """
"""cloud optical properties"""

from .cloud_optical_depth import CloudOpticalDepth
from .cloud_albedo import CloudAlbedo
2 changes: 1 addition & 1 deletion PySDM/products/parcel/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" products specific to the parcel environment """
"""products specific to the parcel environment"""

from .cloud_water_path import ParcelLiquidWaterPath
from .parcel_displacement import ParcelDisplacement
2 changes: 1 addition & 1 deletion PySDM/products/size_spectral/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" products expressing particle size-spectral quantities """
"""products expressing particle size-spectral quantities"""

from .arbitrary_moment import (
RadiusFirstMoment,
2 changes: 1 addition & 1 deletion examples/PySDM_examples/Arabas_et_al_2023/commons.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" ABIFM and INAS parameters and other constants """
"""ABIFM and INAS parameters and other constants"""

from PySDM import Formulae
from PySDM.physics import si
4 changes: 2 additions & 2 deletions examples/PySDM_examples/Pierchala_et_al_2022/commons.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" common data for use in the
[Pierchala et al. 2022](https://doi.org/10.1016/j.gca.2022.01.020) example
"""common data for use in the
[Pierchala et al. 2022](https://doi.org/10.1016/j.gca.2022.01.020) example
"""

from PySDM.physics import constants_defaults as const
2 changes: 1 addition & 1 deletion tests/smoke_tests/box/dejong_azimi/test_box.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" regression tests asserting on values from the plots """
"""regression tests asserting on values from the plots"""

from pathlib import Path

4 changes: 2 additions & 2 deletions tests/smoke_tests/box/partmc/test_dry_wet_equilibration.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
""" comparing kappa-Koehler wet radius equilibration in PySDM and PartMC
(based on PyPartMC-examples notebook by Zach D'Aquino) """
"""comparing kappa-Koehler wet radius equilibration in PySDM and PartMC
(based on PyPartMC-examples notebook by Zach D'Aquino)"""

# pylint: disable=missing-function-docstring,no-member
import platform
2 changes: 1 addition & 1 deletion tests/smoke_tests/conftest.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" borrowing everything from unit_tests (this cannot be one level up due to devops_tests) """
"""borrowing everything from unit_tests (this cannot be one level up due to devops_tests)"""

import pytest

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests for consistency of values taken from the Supplement """
"""tests for consistency of values taken from the Supplement"""

import numpy as np
from PySDM_examples.Pierchala_et_al_2022.commons import deltas_0_SMOW
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" checks how parcel equilibrium supersaturation depends on dz """
"""checks how parcel equilibrium supersaturation depends on dz"""

import numpy as np
from matplotlib import pyplot
6 changes: 3 additions & 3 deletions tests/smoke_tests/parcel_a/lowe_et_al_2019/test_fig_s2.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""
test for supplementary figure 2 in Lowe et al 2019 paper.
checks that values from panels d)-f) are in a reasonable range
and decrease/increase monotonically with updraft velocity
test for supplementary figure 2 in Lowe et al 2019 paper.
checks that values from panels d)-f) are in a reasonable range
and decrease/increase monotonically with updraft velocity
"""

import os
2 changes: 1 addition & 1 deletion tests/smoke_tests/parcel_c/graf_et_al_2019/test_fig_4.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests ensuring values on plots match those in the paper """
"""tests ensuring values on plots match those in the paper"""

from pathlib import Path

2 changes: 1 addition & 1 deletion tests/smoke_tests/parcel_c/graf_et_al_2019/test_table_1.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests ensuring values on plots match those in the paper """
"""tests ensuring values on plots match those in the paper"""

from pathlib import Path

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests ensuring values on plots match those in the paper """
"""tests ensuring values on plots match those in the paper"""

from pathlib import Path

2 changes: 1 addition & 1 deletion tests/smoke_tests/parcel_d/seeding/test_hello_world.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests ensuring values on plots match those in the paper """
"""tests ensuring values on plots match those in the paper"""

from pathlib import Path

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
""" tests ensuring values on plots match those in the paper """
"""tests ensuring values on plots match those in the paper"""

from pathlib import Path

6 changes: 3 additions & 3 deletions tests/unit_tests/attributes/test_impl_attribute_registry.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
""" checks the attribute registry logic mapping attribute names to classes implementing them
and handling different variants of these implementations picked depending on the choice of
dynamics and formulae options """
"""checks the attribute registry logic mapping attribute names to classes implementing them
and handling different variants of these implementations picked depending on the choice of
dynamics and formulae options"""

import pytest

Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.