Skip to content

feat(go-feature-flag)!: Introduce in-process evaluation #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(go-feature-flag)!: Introduce in-process evaluation #1384

wants to merge 21 commits into from

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented May 23, 2025 •
edited
Loading

This PR

This is a complete rebuild of the GO Feature Flag provider.
This version is using a webassembly module to do in-process evaluation inside the provider.

You can still use the remote evaluation if you prefer through the OFREP endpoint of GO Feature Flag.

Things to know:

  • The wasm module is download during the process-resources of maven using this script.
  • The default evaluation method is now the in-process one.
  • If you are using the remote evaluation, we are not managing any cache.
  • The provider is also now supporting tracking method

@thomaspoignant
WIP
08f0721 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
feat!(GOFF): Rewrite of the provider to support in-process evaluation
a5392f1 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
remove unused items
23c7be3 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
load the wasm file with a version
3a7b712 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
Adding automation to download the wasm file
e1b53b1 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
Bump wasm version
5c0ae1e 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
Fix mvn verify errors
1039e6c 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
remove copy of checkstyle file
bc73751 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant requested a review from a team as a code owner May 23, 2025 16:56
@thomaspoignant
remove unused lib
938e5c5 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
Merge branch 'main' into goff-inprocess-eval
a8f0f74 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
removing checkstyle to correct location
911bb67 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
listing targeting dir
c46e582 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
adding log to debug java 21
e0486ed 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
Change stage to download wasm
34c81ff 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
change extension detection
19f8d21 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant force-pushed the goff-inprocess-eval branch 2 times, most recently from a3f31fd to 3e777b2 Compare May 24, 2025 09:33
@thomaspoignant thomaspoignant marked this pull request as draft May 24, 2025 09:35
@thomaspoignant thomaspoignant force-pushed the goff-inprocess-eval branch 5 times, most recently from b328b00 to 25ecbc0 Compare May 24, 2025 10:20
@thomaspoignant thomaspoignant marked this pull request as ready for review May 24, 2025 10:33
@thomaspoignant
Fix some linting issues
e7d1385 
Signed-off-by: Thomas Poignant <[email protected]>
liran2000
liran2000 reviewed May 24, 2025
View reviewed changes
Copy link
Member

@liran2000 liran2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good :)
Added some comments.

Adding a section to the PR and the readme on the motivation to do in-process evaluation inside the provider can be nice too.

@thomaspoignant thomaspoignant force-pushed the goff-inprocess-eval branch 2 times, most recently from 0bbfee1 to 5259359 Compare May 25, 2025 09:40
@github-actions github-actions bot mentioned this pull request May 25, 2025
Open
@thomaspoignant
Update readme
4b234e6 
Signed-off-by: Thomas Poignant <[email protected]>
liran2000
liran2000 reviewed May 25, 2025
View reviewed changes
@thomaspoignant
moving to HttpClient instead of OkHttp
5cf94eb 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant
fix linter
119ecde 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant requested a review from liran2000 May 26, 2025 05:32
@thomaspoignant
Add support scheduled rollout
df6f237 
Signed-off-by: Thomas Poignant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liran2000 liran2000 liran2000 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaspoignant @liran2000