-
Notifications
You must be signed in to change notification settings - Fork 51
feat(go-feature-flag)!: Introduce in-process evaluation #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thomaspoignant
wants to merge
21
commits into
main
Choose a base branch
from
goff-inprocess-eval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,821
−1,933
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
08f0721
WIP
thomaspoignant a5392f1
feat!(GOFF): Rewrite of the provider to support in-process evaluation
thomaspoignant 23c7be3
remove unused items
thomaspoignant 3a7b712
load the wasm file with a version
thomaspoignant e1b53b1
Adding automation to download the wasm file
thomaspoignant 5c0ae1e
Bump wasm version
thomaspoignant 1039e6c
Fix mvn verify errors
thomaspoignant bc73751
remove copy of checkstyle file
thomaspoignant 938e5c5
remove unused lib
thomaspoignant a8f0f74
Merge branch 'main' into goff-inprocess-eval
thomaspoignant 911bb67
removing checkstyle to correct location
thomaspoignant c46e582
listing targeting dir
thomaspoignant e0486ed
adding log to debug java 21
thomaspoignant 34c81ff
Change stage to download wasm
thomaspoignant 19f8d21
change extension detection
thomaspoignant e7d1385
Fix some linting issues
thomaspoignant 76ab14c
Merge branch 'main' into goff-inprocess-eval
thomaspoignant 4b234e6
Update readme
thomaspoignant 5cf94eb
moving to HttpClient instead of OkHttp
thomaspoignant 119ecde
fix linter
thomaspoignant df6f237
Add support scheduled rollout
thomaspoignant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
#!/usr/bin/env bash | ||
|
||
# This script downloads the wasm file from the go-feature-flag repository and adds it to the build. | ||
|
||
wasm_version="v1.45.0" # {{wasm_version}} | ||
|
||
# Set the repository owner and name | ||
repo_owner="thomaspoignant" | ||
repo_name="go-feature-flag" | ||
file_suffix=".wasi" | ||
target_dir="./src/main/resources/wasm/" | ||
|
||
# Function to find the download URL | ||
find_download_url() { | ||
local release_tag=$1 | ||
local file_suffix=$2 | ||
|
||
# Get the assets for the specific release | ||
assets=$(curl -s "https://api.github.com/repos/$repo_owner/$repo_name/releases/tags/$wasm_version" | jq -r '.assets') | ||
|
||
if [ -z "$assets" ]; then | ||
echo "Error: No assets found for release $wasm_version" | ||
return 1 | ||
fi | ||
|
||
# Find the asset that matches the file prefix | ||
download_url=$(echo "$assets" | jq -r ".[] | select(.name | endswith(\"$file_suffix\")) | .browser_download_url") | ||
|
||
if [ -z "$download_url" ]; then | ||
echo "Error: No asset found with prefix '$file_suffix' in release $wasm_version" | ||
return 1 | ||
fi | ||
echo "$download_url" | ||
} | ||
|
||
# Function to download the file | ||
download_file() { | ||
local url=$1 | ||
local target_dir=$2 | ||
|
||
if [ -z "$url" ]; then | ||
echo "Error: Download URL is empty." | ||
return 1 | ||
fi | ||
|
||
if [ -z "$target_dir" ]; then | ||
echo "Error: Target directory is empty." | ||
return 1 | ||
fi | ||
|
||
# Extract the filename from the URL | ||
local filename=$(basename "$url") | ||
|
||
# Check if the directory exists | ||
if [ ! -d "$target_dir" ]; then | ||
mkdir -p "$target_dir" # Create the directory if it doesn't exist | ||
fi | ||
|
||
# Use curl to download the file with progress | ||
echo "Downloading $filename to $target_dir..." | ||
curl -L -o "$target_dir/$filename" "$url" | ||
if [ $? -ne 0 ]; then | ||
echo "Error: Download failed." | ||
return 1 | ||
fi | ||
echo "Download successful!" | ||
} | ||
|
||
# Main script logic | ||
download_url=$(find_download_url "$latest_release" "$file_suffix") | ||
if [ $? -ne 0 ]; then | ||
echo "Error: Failed to find the download URL for release $latest_release." | ||
exit 1 | ||
fi | ||
|
||
download_file "$download_url" "$target_dir" | ||
if [ $? -ne 0 ]; then | ||
echo "Error: Failed to download the file. $download_url" | ||
exit 1 | ||
fi | ||
|
||
ls "$target_dir" | ||
|
||
echo "Done." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/EvaluationResponse.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should likely be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
This is used to build the repo URL where the WASM file is located.
And it is located in the repo
thomaspoignant/go-feature-flag