feat: 611 byo blessed samples#619
Merged
t-fine merged 2 commits intoopen-horizon:masterfrom Jan 22, 2026
Merged
Conversation
bccaf2d to
8e0d601
Compare
dlarson04
approved these changes
Dec 2, 2025
8e0d601 to
b95b538
Compare
b95b538 to
a391241
Compare
dlarson04
approved these changes
Dec 12, 2025
865e2a1 to
a5239b5
Compare
Signed-off-by: Troy Fine <troyfine@Troys-MacBook-Pro-2.local>
a5239b5 to
373e269
Compare
Collaborator
Author
|
Okay I think this is officially ready for review! Some things to note: this will now only publish the custom set of samples if the text file is provided. There is an inconsistency with how the |
joewxboy
approved these changes
Jan 21, 2026
Member
joewxboy
left a comment
There was a problem hiding this comment.
Looks good and functions as expected. Would like to see one or two example blessedSamples.txt files.
Collaborator
Author
|
Thanks for the review @joewxboy I'm going to go ahead and get this merged |
This was referenced Mar 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to test this new feature...
samples.txtfile that contains the gut hub URL to be cloned and published (this repo must contain a Makefile with apublish-onlytarget):