Skip to content

feat: 611 byo blessed samples#619

Merged
t-fine merged 2 commits intoopen-horizon:masterfrom
t-fine:feat_611_byo_blessed_samples
Jan 22, 2026
Merged

feat: 611 byo blessed samples#619
t-fine merged 2 commits intoopen-horizon:masterfrom
t-fine:feat_611_byo_blessed_samples

Conversation

@t-fine
Copy link
Copy Markdown
Collaborator

@t-fine t-fine commented Dec 2, 2025

Steps to test this new feature...

  1. Create a samples.txt file that contains the gut hub URL to be cloned and published (this repo must contain a Makefile with a publish-only target):
root@zyber1:~/byo_test# cat samples.txt 
https://github.com/open-horizon-services/web-helloworld-python.git
  1. Set the following environment variables:
export OH_EXAMPLES_REPO=https://raw.githubusercontent.com/t-fine/examples/refs/heads/feat_611_byo_blessed_samples
export BYO_SAMPLES=samples.txt
  1. Run the AIO script:
curl -sSL https://raw.githubusercontent.com/open-horizon/devops/master/mgmt-hub/deploy-mgmt-hub.sh | bash

@t-fine t-fine force-pushed the feat_611_byo_blessed_samples branch from bccaf2d to 8e0d601 Compare December 2, 2025 17:14
@t-fine t-fine marked this pull request as draft December 2, 2025 18:15
@t-fine t-fine force-pushed the feat_611_byo_blessed_samples branch from 8e0d601 to b95b538 Compare December 2, 2025 18:24
@t-fine t-fine force-pushed the feat_611_byo_blessed_samples branch from b95b538 to a391241 Compare December 11, 2025 18:36
@t-fine t-fine force-pushed the feat_611_byo_blessed_samples branch 2 times, most recently from 865e2a1 to a5239b5 Compare December 12, 2025 18:51
Signed-off-by: Troy Fine <troyfine@Troys-MacBook-Pro-2.local>
@t-fine t-fine force-pushed the feat_611_byo_blessed_samples branch from a5239b5 to 373e269 Compare December 12, 2025 19:04
@t-fine t-fine requested a review from joewxboy December 12, 2025 21:57
@t-fine t-fine marked this pull request as ready for review December 12, 2025 21:57
@t-fine
Copy link
Copy Markdown
Collaborator Author

t-fine commented Dec 12, 2025

Okay I think this is officially ready for review!

Some things to note: this will now only publish the custom set of samples if the text file is provided. There is an inconsistency with how the HZN_ORG_ID is set in the open-horizon/examples so I can't publish both at this moment

Copy link
Copy Markdown
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and functions as expected. Would like to see one or two example blessedSamples.txt files.

@t-fine t-fine merged commit 35fecbc into open-horizon:master Jan 22, 2026
1 of 2 checks passed
@t-fine
Copy link
Copy Markdown
Collaborator Author

t-fine commented Jan 22, 2026

Thanks for the review @joewxboy I'm going to go ahead and get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: extend the functionality of the blessedSamples to accept GitHub repo url

3 participants