Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a new K8s SemConv SIG project #2352

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

ChrsMark
Copy link
Member

The Opentelemetry community would like to work on K8s Semantic Conventions in order to add any missing attributes and/or metrics and stabilize the existing ones. The primary goal of this is to help with the adoption of the respective OTel Collector receivers and processors.

TODOS:

  1. Expand the list of domain experts
  2. Define meeting time
  3. Create the slack channel, agenda doc, calendar event, project board

@ChrsMark
Copy link
Member Author

Pinging relevant people here. Please explicitly ask for being included in the domain experts list if you are not already.

/cc @open-telemetry/semconv-k8s-approvers @open-telemetry/semconv-container-approvers @TylerHelmuth @dmitryax @dashpole @jinja2 @frzifus @mx-psi @povilasv @jamesmoessis @AlexanderWert @rogercoll @braydonk @jsuereth

Feel free to advertise this and/or proposing people for joining this project.

@rogercoll
Copy link
Contributor

Thanks for pushing this SIG @ChrsMark ! I think it is really needed to standardize all the k8s and container metrics, which should help with the alignment between the different collector's related receivers (kubeletstats, dockerstats, podmanstats, etc.)

I would gladly join the SIG and share my domain expertise, specially in the containers area.

@braydonk
Copy link

I support the new SIG! I don't have enough expertise in the general k8s area to join, but will spread the word with some more knowledgeable folks to see who would be interested.

@jaronoff97
Copy link

As a maintainer of the operator and helm charts, id love to be added to this effort. It would be great if we could improve and standardize more in the k8s world.

@gyliu513
Copy link
Member

Thanks @ChrsMark , happy to see this proposal, can we extend this SIG a little bit to cover k8s cost as well by https://github.com/opencost?

@ChrsMark
Copy link
Member Author

Thank's for the suggestion @gyliu513!
This SIG will initially focus on the k8s.* (and a bit of container.*) namespace. The primary focus is to stabilize the basic resource attributes and metrics which are already widely used by the Collector. Then of course we can examine additional semantic conventions.

@gyliu513 do you have specific semantic conventions in mind that you would like to introduce? If so, you can always propose them with an issue and it could be added in the SIG's backlog.

@dmitryax
Copy link
Member

dmitryax commented Sep 19, 2024

Thanks for starting the SIG! I'm happy to help with this effort

@ChrsMark
Copy link
Member Author

Any suggestions/proposals regarding meeting times? I suggest we start with bi-weekly meetings. Looking into https://calendar.google.com/calendar/u/0/embed?src=c_2bf73e3b6b530da4babd444e72b76a6ad893a5c3f43cf40467abc7a9a897f977@group.calendar.google.com, I see Wednesday 8:00am PDT as a good option. Please share your feedback folks.

@dashpole
Copy link

8 am is also the Promethues WG, with I lead, but it is every-other-week. I could join if we also did this project every other week offset from the prometheus wg.

projects/k8s-semconv.md Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

We are still in need of a second sponsor for this SIG. Based on #2361 someone from @open-telemetry/specs-semconv-maintainers can be the 2nd sponsor here.

@AlexanderWert
Copy link
Member

I'm happy to sponsor this effort!

@ChrsMark
Copy link
Member Author

It seems that we have a 2nd sponsor from SemConv maintainers.

We will need to add:

  • a slack channel
  • Google doc for agenda
  • calendar event + zoom meeting
  • project board

But these can be added after we have merged this first PR for the project.

Could we get some eyes from the GC please?

@ChrsMark ChrsMark force-pushed the k8s_semconv_sig branch 3 times, most recently from e4a62e3 to 6c489ce Compare September 26, 2024 13:54
@trask
Copy link
Member

trask commented Sep 26, 2024

@AlexanderWert can you review/approve? thanks!

@svrnm svrnm added the area/project-proposal Submitting a filled out project template label Sep 30, 2024
@trask
Copy link
Member

trask commented Sep 30, 2024

@open-telemetry/governance-committee please review, I think we decided we want approvals from majority of GC for new projects

I've added this to Thursday's Governance Committee meeting agenda in case we don't have enough GC approvals by then

Copy link
Contributor

@tedsuo tedsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid proposal 👍

@mtwo mtwo merged commit 88cfdaa into open-telemetry:main Oct 1, 2024
4 checks passed
@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 2, 2024

I have filed #2371 to add the project board.

We will still need a slack channel, Google doc for agenda and a calendar event + zoom meeting. Could someone from @open-telemetry/governance-committee help with those? We also need a GC liaison to be assigned to this project.

@ChrsMark ChrsMark mentioned this pull request Oct 2, 2024
3 tasks
@trask
Copy link
Member

trask commented Oct 2, 2024

We will still need a slack channel, Google doc for agenda and a calendar event + zoom meeting. Could someone from @open-telemetry/governance-committee help with those?

this should be done now: #2372 (comment)

We also need a GC liaison to be assigned to this project.

I've added this topic to this week's GC meeting agenda

@trask
Copy link
Member

trask commented Oct 3, 2024

I've added this topic to this week's GC meeting agenda

see #2377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/project-proposal Submitting a filled out project template
Projects
Status: Current Projects
Development

Successfully merging this pull request may close these issues.