app-server: preserve legacy cwd strings in exec events#29472
Closed
anp-oai wants to merge 7 commits into
Closed
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f919194e9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 22, 2026
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 985644dccf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 22, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 22, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 22, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 22, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
force-pushed
the
codex/legacy-exec-event-cwd
branch
from
63d55da to
7453a92
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
force-pushed
the
codex/legacy-exec-event-cwd
branch
from
7453a92 to
9b23284
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
force-pushed
the
codex/legacy-exec-event-cwd
branch
from
4ec2fbf to
f7d5959
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
anp-oai
force-pushed
the
codex/legacy-exec-event-cwd
branch
from
f7d5959 to
2233689
Compare
Collaborator
Author
|
This is overkill, the path that codex proposed for these to end up in rollouts was only an experimental feature that has since been removed. |
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
## Why I'd originally added `PathUri` legacy path deserialization thinking we'd want it for having `PathUri` in public app-server APIs. Since then we've added `LegacyAppPathString` to handle the messy conversions that we need for backcompat. It's confusing for `PathUri` to support deserializing legacy paths when we don't yet want to actually expose app-server callers or rollout storage to the new URI format. Stacked on top of #29472 to avoid breaking compatibility in case those types ended up stored somewhere for someone. ## What changed - Parse deserialized `PathUri` values exclusively as valid `file:` URIs. - Replace legacy acceptance coverage with rejection coverage for top-level filesystem paths and sandbox working directories. - Serialize CWDs in hand-built exec-server process requests as `PathUri` values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Command lifecycle events can end up on the wire or on disk in some configurations. This undoes the overeager conversion of their cwd's to PathUri, and also adds tests to ensure that any rollouts with these events written as
file:///...will deserialize successfully.What
LegacyAppPathStringin exec command begin/end events.PathUrivalues at emission and restore them only for app-server command-action resolution.to_inferred_path_uri.