feat: moving retirement code to enterprise#2559
Conversation
| """ | ||
| Perform one-time initialization: connect signal handlers. | ||
| """ | ||
| import integrated_channels.integrated_channel.signals # noqa: F401 pylint: disable=import-outside-toplevel,unused-import |
There was a problem hiding this comment.
👍 Looks like claude version of this PR got this slightly wrong by doing the connect() call inside ready() which technically works but is less clean.
| name = 'integrated_channels.integrated_channel' | ||
| verbose_name = "Enterprise Integrated Channels" | ||
|
|
||
| def ready(self): |
There was a problem hiding this comment.
FYI, integrated_channels is deprecated, we migrated to channel_integrations. Confusingly, BOTH are still installed and active:
- https://github.com/edx/edx-platform/blob/c70bfe980a5b56837d8b9e2fc00203c57b228682/lms/envs/common.py#L2032-L2033
- https://github.com/edx/edx-platform/blob/bcddf9cd539ceb1edba061057590992d49f5334b/openedx/envs/common.py#L770-L772
Your hunch was correct to migrate these because they are indeed functions we currently call during retirement, but unfortunately I think they're no-ops since the old tables just don't get updated anymore.
Please just add a code comment that we should really move these integrated-channel-specific retirement handlers again to the edx-integrated-channels repository and update the handlers to import the new models of the same name.
pwnage101
left a comment
There was a problem hiding this comment.
left a dangling pending review
cc39c40 to
591f3fc
Compare
This PR is related to this one in edx-platform, where we are migrating static methods from edx-platform to the edx-enterprise library.
Jira ticket
Merge checklist:
requirements/*.txtfiles)base.inif needed in production but edx-platform doesn't install ittest-master.inif edx-platform pins it, with a matching versionmake upgrade && make requirementshave been run to regenerate requirementsmake statichas been run to update webpack bundling if any static content was updated./manage.py makemigrationshas been run./manage.py lms makemigrationsin the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein edx-platform will look for the latest version in PyPi.