Skip to content

build: remove old constraints and upgrade#287

Merged
iloveagent57 merged 1 commit intomasterfrom
aed/modern-constraints
Feb 3, 2026
Merged

build: remove old constraints and upgrade#287
iloveagent57 merged 1 commit intomasterfrom
aed/modern-constraints

Conversation

@iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Feb 2, 2026

  • remove outdated constraints
  • make target to create a venv
  • use constraints in pip.in
  • upgrade python deps

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

@openedx-webhooks
Copy link

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Feb 2, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 2, 2026
@iloveagent57 iloveagent57 force-pushed the aed/modern-constraints branch 4 times, most recently from 1dfaafd to 754433d Compare February 2, 2026 17:11
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the venv make target which seems unused.

@echo "Please use \`make <target>' where <target> is one of"
@awk -F ':.*?## ' '/^[a-zA-Z]/ && NF==2 {printf "\033[36m %-25s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST) | sort

venv: ## create a virtualenv if it doesn't exist, then activate it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a convenience for use within containers to manage deps independently of the app the container primarily runs.

keep algoliasearch pinned at 2
@iloveagent57 iloveagent57 force-pushed the aed/modern-constraints branch from 754433d to 1449b52 Compare February 2, 2026 20:30
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Feb 3, 2026
@iloveagent57 iloveagent57 reopened this Feb 3, 2026
@iloveagent57 iloveagent57 merged commit 3b842b7 into master Feb 3, 2026
10 of 16 checks passed
@iloveagent57 iloveagent57 deleted the aed/modern-constraints branch February 3, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants