8358572: C1 hits "need debug information" assert with -XX:-DeoptC1

[mhaessig]

The debug flag DeoptC1 is required to be true for dependency recording by an assert, but not all uses of dependency recording in C1 are guarded with if (DeoptC1). Hence, running java -XX:-DeoptC1 -versionfails at the aforementioned assert.

This error has been present unconditionally in debug builds since dependency recording was enabled outside of JVMTI in JDK-8324241 and at least since JDK7 with JVMTI. Because this issue was discovered by searching for crashes of java -version plus some other flag, which indicates this flag has not been used in at least one year since every invocation with -XX:-DeoptC1crashes. Further, DeoptC1 is only used for guarding dependency recording in three places. Thus, this PR removes the DeoptC1 flag.

This was tested with:

• Github Actions
• tier1, tier2 plus Oracle internal testing on Oracle supported platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358572: C1 hits "need debug information" assert with -XX:-DeoptC1 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25900/head:pull/25900
$ git checkout pull/25900

Update a local copy of the PR:
$ git checkout pull/25900
$ git pull https://git.openjdk.org/jdk.git pull/25900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25900

View PR using the GUI difftool:
$ git pr show -t 25900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25900.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6687eac8)