Skip to content

8358572: C1 hits "need debug information" assert with -XX:-DeoptC1 #25900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8358572: C1 hits "need debug information" assert with -XX:-DeoptC1 #25900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/c1/c1_Compilation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ ciKlass* Compilation::cha_exact_type(ciType* type) {
if (type != nullptr && type->is_loaded() && type->is_instance_klass()) {
ciInstanceKlass* ik = type->as_instance_klass();
assert(ik->exact_klass() == nullptr, "no cha for final klass");
if (DeoptC1 && UseCHA && !(ik->has_subklass() || ik->is_interface())) {
if (UseCHA && !(ik->has_subklass() || ik->is_interface())) {
dependency_recorder()->assert_leaf_type(ik);
return ik;
}
Expand Down
5 changes: 2 additions & 3 deletions src/hotspot/share/c1/c1_GraphBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1855,7 +1855,6 @@ void GraphBuilder::access_field(Bytecodes::Code code) {


Dependencies* GraphBuilder::dependency_recorder() const {
assert(DeoptC1, "need debug information");
return compilation()->dependency_recorder();
}

Expand Down Expand Up @@ -2001,7 +2000,7 @@ void GraphBuilder::invoke(Bytecodes::Code code) {
ciMethod* cha_monomorphic_target = nullptr;
ciMethod* exact_target = nullptr;
Value better_receiver = nullptr;
if (UseCHA && DeoptC1 && target->is_loaded() &&
if (UseCHA && target->is_loaded() &&
!(// %%% FIXME: Are both of these relevant?
target->is_method_handle_intrinsic() ||
target->is_compiled_lambda_form()) &&
Expand Down Expand Up @@ -2252,7 +2251,7 @@ bool GraphBuilder::direct_compare(ciKlass* k) {
if (ik->is_final()) {
return true;
} else {
if (DeoptC1 && UseCHA && !(ik->has_subklass() || ik->is_interface())) {
if (UseCHA && !(ik->has_subklass() || ik->is_interface())) {
// test class is leaf class
dependency_recorder()->assert_leaf_type(ik);
return true;
Expand Down
3 changes: 0 additions & 3 deletions src/hotspot/share/c1/c1_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,6 @@
develop(bool, GenerateArrayStoreCheck, true, \
"Generates code for array store checks") \
\
develop(bool, DeoptC1, true, \
"Use deoptimization in C1") \
\
develop(bool, PrintBailouts, false, \
"Print bailout and its reason") \
\
Expand Down