8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler

[MBaesken]

test\jdk\java\foreign\sharedclosejvmti\libSharedCloseAgent.cpp fails with VS2019 and some versions of VS2022 compilers as follows

========================8<------------------------
* For target support_test_jdk_jtreg_native_support_libSharedCloseAgent_libSharedCloseAgent.obj:
libSharedCloseAgent.cpp
z:\BuildAgent\work\23f345c5c4b56004\test\jdk\java\foreign\sharedclosejvmti\libSharedCloseAgent.cpp(105): fatal error C1001: Internal compiler error.
(compiler file 'msc1.cpp', line 1603)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler (Bug - P4)

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28739/head:pull/28739
$ git checkout pull/28739

Update a local copy of the PR:
$ git checkout pull/28739
$ git pull https://git.openjdk.org/jdk.git pull/28739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28739

View PR using the GUI difftool:
$ git pr show -t 28739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28739.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler

Reviewed-by: jvernee, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 655e9cd: 8373335: Serial: Clean up SerialHeap members by access specifies
• b58e3b6: 8373227: Test java/net/httpclient/http2/StreamFlowControlTest.java failed: should sleep time be raised?
• 8eaeb69: 8372589: VM crashes on init when NonNMethodCodeHeapSize is set too small and UseTransparentHugePages is enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (32ac98d9)

[JornVernee]

I used {} to zero initialize all the fields of this struct. I see other use cases are also using memset to zero out the struct.

[TheRealMDoerr]

LGTM.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit b46aef8.
Since your change was applied there have been 9 commits pushed to the master branch:

• 920a99f: 8370731: Tests in vmTestbase/nsk/monitoring/GarbageCollectorMXBean/CollectionCounters/ failed: OutOfMemoryError
• 74dca86: 8371718: (sc) Channels.new{Input,Output}Stream can allocate unbounded memory for a socket channel
• 52aa7fe: 8334549: [Sound] Test timed out: javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java
• ... and 6 more: https://git.openjdk.org/jdk/compare/b60ac710bebf195972436da324983e61b51484ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit b46aef8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.