Skip to content

8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler #28739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MBaesken wants to merge 1 commit into from
Closed

8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler #28739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/jdk/java/foreign/sharedclosejvmti/libSharedCloseAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ Agent_OnLoad(JavaVM *vm, char *options, void *reserved) {
return jni_err;
}

jvmtiCapabilities capabilities{};
jvmtiCapabilities capabilities;
memset(&capabilities, 0, sizeof(jvmtiCapabilities));
Comment on lines +105 to +106
Copy link
Member

@JornVernee JornVernee Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used {} to zero initialize all the fields of this struct. I see other use cases are also using memset to zero out the struct.

capabilities.can_generate_method_exit_events = 1;

jvmtiError err = env->AddCapabilities(&capabilities);
Expand Down