Update npm install command to use --os flag #985
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 145beb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
conico974
reviewed
Sep 24, 2025
|
|
||
| const additionalArgs = installOptions.additionalArgs ?? ""; | ||
| const installCommand = `npm install --platform=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`; | ||
| const installCommand = `npm install --os=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`; |
There was a problem hiding this comment.
We should provide both if it does not cause any issue, not just replace it
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@opennextjs/aws": minor | |||
There was a problem hiding this comment.
It's a patch, not a minor
| // For SHARP_IGNORE_GLOBAL_LIBVIPS see: https://github.com/lovell/sharp/blob/main/docs/install.md#aws-lambda | ||
|
|
||
| const sharpVersion = process.env.SHARP_VERSION ?? "0.32.6"; | ||
| const sharpVersion = process.env.SHARP_VERSION ?? "0.34.4"; |
There was a problem hiding this comment.
Do we have to bump that one ? Did you test it against other versions of Next ?
OpenNext support Next 12, it has to work from Next 12 to 15
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a problem where sharp after 0.36.2 would not install correctly.
--osinstead of platformsharpto latest version