Skip to content

Update npm install command to use --os flag #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

Update npm install command to use --os flag #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1877ce8
fix: Update npm install command to use --os flag for sharp >0.32.6
niklaswallerstedt Sep 23, 2025
145beb3
adds changeset
niklaswallerstedt Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-mangos-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a patch, not a minor

---

Update npm install command to use --os flag
2 changes: 1 addition & 1 deletion packages/open-next/src/build/createImageOptimizationBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export async function createImageOptimizationBundle(
// Target should be same as used by Lambda, see https://github.com/sst/sst/blob/ca6f763fdfddd099ce2260202d0ce48c72e211ea/packages/sst/src/constructs/NextjsSite.ts#L114
// For SHARP_IGNORE_GLOBAL_LIBVIPS see: https://github.com/lovell/sharp/blob/main/docs/install.md#aws-lambda

const sharpVersion = process.env.SHARP_VERSION ?? "0.32.6";
const sharpVersion = process.env.SHARP_VERSION ?? "0.34.4";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to bump that one ? Did you test it against other versions of Next ?
OpenNext support Next 12, it has to work from Next 12 to 15


installDependencies(
outputPath,
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/build/installDeps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function installDependencies(
: "";

const additionalArgs = installOptions.additionalArgs ?? "";
const installCommand = `npm install --platform=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`;
const installCommand = `npm install --os=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide both if it does not cause any issue, not just replace it

execSync(installCommand, {
stdio: "pipe",
cwd: tempInstallDir,
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/types/open-next.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ export interface InstallOptions {
* @example
* ```ts
* install: {
* packages: ["sharp@0.32"]
* packages: ["sharp@0.34"]
* }
* ```
*/
Expand Down
Loading