Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kv cache #194

Merged
merged 8 commits into from
Dec 20, 2024
Merged

feat: kv cache #194

merged 8 commits into from
Dec 20, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 19, 2024

The blog example works 🎉

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0612b61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 19, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@194

commit: 0612b61

@vicb vicb force-pushed the local/exp branch 4 times, most recently from d76df36 to d342844 Compare December 19, 2024 20:13
conico974
conico974 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i've just added a few comment

@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

Very valuable review @conico974, thanks a lot!

@vicb vicb mentioned this pull request Dec 20, 2024
Merged
@vicb vicb force-pushed the local/exp branch 3 times, most recently from e3c4112 to 734fa83 Compare December 20, 2024 12:27
@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

@conico974 I think I have addressed all the feedback - thanks for your help!

Tested both fetch and page cache successfully 🎉

PTAL

@vicb vicb requested a review from conico974 December 20, 2024 12:28
@vicb vicb mentioned this pull request Dec 20, 2024
Merged
conico974
conico974 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vicb vicb merged commit eb0781a into experimental Dec 20, 2024
6 checks passed
@vicb vicb deleted the local/exp branch December 20, 2024 14:11
vicb added a commit that referenced this pull request Dec 20, 2024
@vicb @conico974
feat: kv cache (#194)
2313248 
Co-authored-by: conico974 <[email protected]>
vicb added a commit that referenced this pull request Dec 20, 2024
@vicb @conico974
feat: kv cache (#194)
6183c4a 
Co-authored-by: conico974 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

@james-elicx james-elicx Awaiting requested review from james-elicx

@dario-piotrowicz dario-piotrowicz Awaiting requested review from dario-piotrowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974