Skip to content

docs(claude): update rules to reflect current architecture and workflow#329

Merged
AugustoL merged 2 commits intoopenscan-explorer:devfrom
AugustoL:docs/update-claude-rules
Mar 19, 2026
Merged

docs(claude): update rules to reflect current architecture and workflow#329
AugustoL merged 2 commits intoopenscan-explorer:devfrom
AugustoL:docs/update-claude-rules

Conversation

@AugustoL
Copy link
Collaborator

Description

Update Claude Code instruction files to reflect the current state of the codebase and project workflow.

Related Issue

N/A — documentation maintenance

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Performance improvement
  • Other (please describe):

Changes Made

  • workflow.md: Dual workflow strategy — patch releases go directly to dev, minor/major releases use release branches
  • architecture.md: Updated from old fetcher/adapter structure to current NetworkAdapter abstract class with AdapterFactory. Added Bitcoin and Hardhat adapters
  • patterns.md: Fixed component paths (evm/address/shared/), updated "adding a new network" steps to use AdapterFactory
  • i18n.md: Updated supported languages from 2 to 5 (en, es, ja, pt-BR, zh), added tooltips namespace, updated all checklists
  • code-style.md: Updated i18n verification to reference all 5 locales

Checklist

  • I have run npm run format:fix and npm run lint:fix
  • I have run npm run typecheck with no errors
  • I have tested my changes locally
  • I have updated documentation if needed
  • My code follows the project's architecture patterns

- workflow: add dual strategy (patch PRs to dev, release branches for minor/major)
- architecture: update to NetworkAdapter/AdapterFactory pattern, add Bitcoin and Hardhat
- patterns: fix paths, update "add network" steps to new adapter structure
- i18n: add 5 supported languages, tooltips namespace, update checklists
- code-style: reference all 5 locales in i18n verification
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

🚀 Preview: https://pr-329--openscan.netlify.app
📝 Commit: 743e1716f719388367e44c8b4182186ec5717cf3

Copy link
Collaborator

@josealoha666 josealoha666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of doc updates still do not match the current tree:

  1. .claude/rules/i18n.md adds a tooltips namespace, but there is no src/locales/*/tooltips.json in this branch.
  2. The new guidance to add keys to src/locales/{es,ja,pt-BR,zh}/{namespace}.json is too broad as written: some namespaces are not present in every locale today (for example rpcs.json exists in en/es but not in ja/pt-BR/zh).

Can you align the rule text with the actual locale layout in the repo, or add the missing locale files/namespaces if that is the intended source of truth?

@AugustoL AugustoL merged commit a2f4b87 into openscan-explorer:dev Mar 19, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants