-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45205: flake "kubelet terminates kube-apiserver gracefully extended" #29552
base: master
Are you sure you want to change the base?
Conversation
@atiratree: This pull request references Jira Issue OCPBUGS-45205, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atiratree The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@atiratree: This pull request references Jira Issue OCPBUGS-45205, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f912008
to
1bb358d
Compare
Job Failure Risk Analysis for sha: 1bb358d
|
/retest |
@atiratree: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@@ -96,7 +96,7 @@ var _ = g.Describe("[sig-api-machinery][Feature:APIServer][Late]", func() { | |||
} | |||
} | |||
if len(finalMessageBuilder.String()) > 0 { | |||
g.GinkgoT().Errorf("The following API Servers weren't gracefully terminated: %v", finalMessageBuilder.String()) | |||
result.Flakef("The following API Servers weren't gracefully terminated. Probably kubelet or CRI-O is not giving the time to cleanly shut down. This can lead to connection refused and network I/O timeout errors in other components.\n\n%s", finalMessageBuilder.String()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we going to let the node team know that they should take a look and propose a fix ? or is this an issue with the test ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test fine, just that the kubelet cannot ensure the gracefully termination during the node restart. I will ask the node team for a confirmation. Btw, I have copy pasted the new error message from the test above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind tagging this test as flaky as long as the node team is aware of the issue and is willing to fix it in the future.
No description provided.