Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45205: flake "kubelet terminates kube-apiserver gracefully extended" #29552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-45205: flake "kubelet terminates kube-apiserver gracefully extended" #29552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/apiserver/graceful_termination.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ var _ = g.Describe("[sig-api-machinery][Feature:APIServer][Late]", func() {
}
}
if len(finalMessageBuilder.String()) > 0 {
g.GinkgoT().Errorf("The following API Servers weren't gracefully terminated: %v", finalMessageBuilder.String())
result.Flakef("The following API Servers weren't gracefully terminated. Probably kubelet or CRI-O is not giving the time to cleanly shut down. This can lead to connection refused and network I/O timeout errors in other components.\n\n%s", finalMessageBuilder.String())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to let the node team know that they should take a look and propose a fix ? or is this an issue with the test ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test fine, just that the kubelet cannot ensure the gracefully termination during the node restart. I will ask the node team for a confirmation. Btw, I have copy pasted the new error message from the test above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind tagging this test as flaky as long as the node team is aware of the issue and is willing to fix it in the future.

}
})

Expand Down