Add "skipped-versions" index.json field for the ability to skip testing of broken library versions #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jormundur00
force-pushed
the
jormundur00/gh-757
branch
from
7c63359 to
e3603db
Compare
vjovanov
reviewed
Nov 20, 2025
docs/CONTRIBUTING.md
Outdated
| }, | ||
| { | ||
| "version": "1.0.7", | ||
| "reason": "Resource metadata provided in reflect-config.json." |
Member
There was a problem hiding this comment.
This is not a reason to skip, only if it fails. We need maven issues here, broken builds etc.
Member
Author
There was a problem hiding this comment.
I've changed the example reason to Integrated reflect-config.json does not parse. (which reflects the issue in practice with the opentelemetry:1.34.0 libraries).
| "skipped-versions": [ | ||
| { | ||
| "version": "1.34.0", | ||
| "reason": "Dependency io.opentelemetry:opentelemetry-api:1.34.0 provides resource metadata inside of a reflect-config.json file." |
Member
There was a problem hiding this comment.
reflect-config.json that does not parse.
| } | ||
| } | ||
|
|
||
| static List<String> getSkippedVersions(String libraryModule) { |
| null, | ||
| coordinates.version(), | ||
| List.of(coordinates.version())); | ||
| List.of(coordinates.version()), |
| List<String> testedVersions | ||
| List<String> testedVersions, | ||
| @JsonProperty("skipped-versions") | ||
| List<SkippedVersionEntry> skippedVersions |
Member
There was a problem hiding this comment.
Do build tools care about this?
Member
Author
There was a problem hiding this comment.
AFAICT, build tools look for specific fields by string when parsing index.json, so any additional fields will just be ignored. This change shouldn't affect build tools.
…g of broken library versions
jormundur00
force-pushed
the
jormundur00/gh-757
branch
from
a812f6e to
d01e9ac
Compare
vjovanov
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we introduce a
skipped-versionsfield to the individual librariesindex.jsonfile. This field contains a list of(version, reason)pairs which define versions that we skip testing for, for the reason listed in thereasonfield.When fetching versioned libraries for testing, library versions listed in
skipped-versionsare omitted from testing.Fixes: #757, #743, #734.