-
Notifications
You must be signed in to change notification settings - Fork 109
Add "skipped-versions" index.json field for the ability to skip testing of broken library versions #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "skipped-versions" index.json field for the ability to skip testing of broken library versions #792
Changes from all commits
37e386d
abb7261
d01e9ac
ecbd885
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,5 +13,7 @@ public record MetadataVersionsIndexEntry ( | |
| @JsonProperty("metadata-version") | ||
| String metadataVersion, | ||
| @JsonProperty("tested-versions") | ||
| List<String> testedVersions | ||
| List<String> testedVersions, | ||
| @JsonProperty("skipped-versions") | ||
| List<SkippedVersionEntry> skippedVersions | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do build tools care about this?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AFAICT, build tools look for specific fields by string when parsing |
||
| ){} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package org.graalvm.internal.tck.model; | ||
|
|
||
| /** | ||
| * Represents a version of a library that should be skipped during testing, | ||
| * along with the reason why this version is skipped. | ||
| */ | ||
| public record SkippedVersionEntry( | ||
| String version, | ||
| String reason | ||
| ){} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment please.