Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors from graphQl result #396

Closed
wants to merge 1 commit into from
Closed

Log errors from graphQl result #396

wants to merge 1 commit into from

Conversation

mauriau
Copy link

@mauriau mauriau commented Oct 1, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Documented? no
Fixed tickets #379
License MIT

Just add a logger to catch errors from graphQl results

@mcg-web
Copy link
Member

mcg-web commented Oct 2, 2018

Thank you @mauriau for contributing, I'm not really sure that user error should be log backend side as errors. Maybe to make this more friendly we should have a config to choose the log level (default: debug or notice), what do you think of that?

@mauriau mauriau mentioned this pull request Nov 13, 2018
@mcg-web mcg-web closed this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants