Skip to content

Sa additional ipv6 #7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 4, 2025
Merged

Sa additional ipv6 #7875

merged 24 commits into from
Jun 4, 2025

Conversation

SlimJ4
Copy link
Contributor

@SlimJ4 SlimJ4 commented May 16, 2025

What type of Pull Request is this?

  • Update of existing guide(s)

Description

Adding disclaimers that inform users about the usage of vRack with IPv4 and IPv6, and about the concepts of Primary and Additional IPs

Mandatory information

  • This Pull Request can be merged as soon as possible.

SlimJ4 added 2 commits April 3, 2025 16:19
First few changes on category 3 and 4 guides. Still needs primary/additional IP references.
+ Requested edits to the IPv6 in vRack guide.
Disclaimers finished with links to relevant articles.
@SlimJ4 SlimJ4 added the Do not merge yet This Pull Request is awaiting a GO from product teams label May 16, 2025
@SlimJ4
Copy link
Contributor Author

SlimJ4 commented May 16, 2025

ToDo before merging:

@SlimJ4 SlimJ4 requested review from jslocinski and Y0Coss May 19, 2025 15:07
Copy link
Collaborator

@Y0Coss Y0Coss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replicate suggestions to other similar text blocks.
As mentioned, the links must be edited again, so that there is no final / in them.

SlimJ4 and others added 13 commits May 21, 2025 14:25
Removed final "/" in links to avoid issues in prod.
Edited for clarity.
Removed the final "/" in links to avoid issues in prod.
Removed the final "/" in links to avoid issues in prod.
Removed the final "/" in links to avoid issues in prod.
Removed the final "/" in links to avoid issues in prod.
@SlimJ4
Copy link
Contributor Author

SlimJ4 commented May 21, 2025

I will edit the rest of the documents in accordance to the suggestions @Y0Coss made later today - I'll request another review by tomorrow morning. Committed the suggested edits in the meanwhile.

@SlimJ4
Copy link
Contributor Author

SlimJ4 commented May 28, 2025

I will edit the rest of the documents in accordance to the suggestions @Y0Coss made later today - I'll request another review by tomorrow morning. Committed the suggested edits in the meanwhile.

Made the requested changes later than expected. Requesting another review.

@SlimJ4 SlimJ4 requested a review from Y0Coss May 28, 2025 13:34
@Y0Coss
Copy link
Collaborator

Y0Coss commented Jun 3, 2025

@tcpdumpfbacke, can you please check the DE versions?

@Y0Coss Y0Coss merged commit c09fe71 into develop Jun 4, 2025
@Y0Coss Y0Coss deleted the sa-additional-ipv6 branch June 4, 2025 12:50
@Y0Coss
Copy link
Collaborator

Y0Coss commented Jun 4, 2025

Thank you for your contribution @SlimJ4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge yet This Pull Request is awaiting a GO from product teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants