-
Notifications
You must be signed in to change notification settings - Fork 10
tools, image: multi-board images with support for Cosmo #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! Caveat that we'll want to change it at some point to use the AHIB app stuff, but good to go for now.
In conjunction with oxidecomputer/amd-host-image-builder#245, this is working with ahib's xtask.
|
Checking the contents of the generated tar file artefact:
|
Very cool. The AHIB change you made is now in. It occurs to me somewhat belatedly that one could probably give the relative path to the config file in the app, which would be a nice centralization, but I think we can address that when we move to integrate the app thing directly into ahib itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo Josh's comment about the anyhow::anyhow
import, this LGTM.
This change generalises "gimlet" into "compute sled" in a number of places and extends the
helios-build image
command to produce multiple image phase 1 files (one per board) against a single phase 2.