chore(node): gate otlp-only code and silence unused warnings #20034
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 29, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
can this also feature gate the deps entirely?
crates/node/core/src/args/trace.rs
Outdated
Comment on lines
7
to
8
| #[cfg(feature = "otlp")] | ||
| use reth_tracing_otlp::OtlpConfig; |
Collaborator
There was a problem hiding this comment.
this should be replaced with full path imports
conomist
commented
Nov 29, 2025
Author
conomist
left a comment
conomist
left a comment
There was a problem hiding this comment.
work has done according your comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move OtlpConfig behind #[cfg(feature = "otlp")] so it only compiles when the feature is enabled
silence the unused layers parameter for builds without otlp by explicitly binding it under the same cfg guard
keeps the tracing logic untouched when the feature is on while removing noise for minimal builds