Skip to content

chore(node): gate otlp-only code and silence unused warnings #20034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

chore(node): gate otlp-only code and silence unused warnings #20034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdf559
Update trace.rs
conomist Nov 28, 2025
54a9c02
Update trace.rs
conomist Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/node/core/src/args/trace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ impl TraceArgs {
/// Note: even though this function is async, it does not actually perform any async operations.
/// It's needed only to be able to initialize the gRPC transport of OTLP tracing that needs to
/// be called inside a tokio runtime context.
pub async fn init_otlp_tracing(
&mut self,
_layers: &mut Layers,
) -> eyre::Result<OtlpInitStatus> {
pub async fn init_otlp_tracing(&mut self, layers: &mut Layers) -> eyre::Result<OtlpInitStatus> {
#[cfg(not(feature = "otlp"))]
let _ = layers;
if let Some(endpoint) = self.otlp.as_mut() {
self.protocol.validate_endpoint(endpoint)?;

Expand Down