Fix inline menu option wrapping #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace tab character separator with two spaces in inline menus to prevent unpredictable wrapping when rendered in fixed-width table columns. Tab characters expand to the next tab stop (typically 8 characters), which can cause menu options to wrap to new lines in narrow layouts.
|
Thanks for adding the Below is the changelog that will be used for the release. Fix inline menu option wrapping by using spaces instead of tabs. When using inline menus (e.g., Before: After: This release was contributed by @patrick91 in #44 |
|
This PR was published as 0.17.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When using inline menus (e.g.,
app.confirm()), the options were being rendered with tab characters as separators. Tab characters expand to the next tab stop (typically 8 characters), which caused the menu to be too wide for the fixed-width table column layout used by TaggedStyle. This resulted in the "No" option wrapping to a new line.Solution
Changed the separator for inline menus from
"\t"to" "(two spaces) insrc/rich_toolkit/styles/base.py:302. This provides consistent, predictable spacing that fits within the column layout without wrapping.Testing
Tested with
examples/demos/basic_usage.py- the "Yes" and "No" options now appear on the same line as intended.