Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more intuitive arguments to default.launch #60

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

egordon
Copy link
Collaborator

@egordon egordon commented Aug 25, 2021

(1) Add all controllers from personalrobotics/pr_ros_controllers#26 to YAML file for use.

(2) Modify default.launch to be sensitive to arm version and DOF. In preparation for making the repo more robot-agnostic.

Note: this should not change any functionality as-is. It is mostly a refactor in preparation for future PRs.


Before creating a pull request

  • [ N/A ] Document new methods and classes
  • [ N/A ] Format code with make format

Before merging a pull request

  • [ N/A ] Add unit test(s) for this change

@egordon egordon requested review from amalnanavati and a team August 25, 2021 01:31
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm approving because the comments are either minor or just clarifying comments. If you end up addressing the minor comment I'll re-approve, but I also think it's fine to merge it in as-is.

@egordon egordon merged commit 55bdd44 into master Aug 31, 2021
@egordon egordon deleted the egordon/gen26dof branch August 31, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants