Javascript string cleanup #9405
Conversation
WalkthroughThis PR standardizes and refines user-facing text across multiple pgAdmin modules, including adding trailing periods to validation messages and help text, fixing grammar (e.g., "cannot" vs "can not"), correcting typos (e.g., "authenticatation"), and improving message clarity without affecting functionality or control flow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~10 minutes All changes are homogeneous text/punctuation corrections with no functional impact, control-flow modifications, or logic changes. The consistent pattern of standardization (trailing periods, grammar normalization) across files requires straightforward verification that corrections are grammatically sound and contextually appropriate. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
web/pgadmin/tools/import_export/__init__.py (1)
326-343: File validation messages are now consistent; minor duplication remainsAdding the trailing period to
"Please specify a valid file."improves consistency with other error messages, and using the same text for both “missing” and “invalid” cases is acceptable.If you want to go a step further later, you could factor this repeated message into a constant or slightly differentiate the messages for “missing” vs “invalid” file, but that’s optional given the scope of this PR.
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
597-600: Backup notes improved; consider slight tweak to objects help text
- The server note about PLAIN format is clear and accurate.
- For the objects tree help text, consider a slightly smoother phrasing such as:
- helpMessage: gettext('If Schema(s) is selected then it will take the backup of the selected schema(s) only.'), + helpMessage: gettext('If schema(s) are selected, only the selected schema(s) will be backed up.'),This avoids the “it will take the backup” construction and reads more naturally.
Also applies to: 739-748
web/pgadmin/misc/cloud/static/js/aws_schema.ui.js (1)
102-105: Clarify AWS session token help sentenceThe new wording is much clearer than before. For slightly more natural English, you might add “is”:
- helpMessage: gettext('Session token required for temporary AWS sessions.') + helpMessage: gettext('Session token is required for temporary AWS sessions.')Purely stylistic; behavior is unchanged either way.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
web/pgadmin/authenticate/mfa/views.py(1 hunks)web/pgadmin/browser/register_browser_preferences.py(9 hunks)web/pgadmin/browser/register_editor_preferences.py(1 hunks)web/pgadmin/browser/server_groups/servers/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_jobs/static/js/dbms_job.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_schedules/static/js/dbms_schedule.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/databases/schemas/fts_parsers/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js(2 hunks)web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js(4 hunks)web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/roles/__init__.py(1 hunks)web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js(4 hunks)web/pgadmin/browser/static/js/withCheckPermission.js(1 hunks)web/pgadmin/browser/templates/browser/js/messages.js(1 hunks)web/pgadmin/dashboard/__init__.py(2 hunks)web/pgadmin/misc/bgprocess/processes.py(2 hunks)web/pgadmin/misc/cloud/static/js/aws_schema.ui.js(1 hunks)web/pgadmin/misc/cloud/static/js/azure.js(1 hunks)web/pgadmin/misc/cloud/static/js/azure_schema.ui.js(1 hunks)web/pgadmin/misc/cloud/static/js/google.js(1 hunks)web/pgadmin/misc/cloud/static/js/google_schema.ui.js(1 hunks)web/pgadmin/tools/backup/static/js/backup.ui.js(2 hunks)web/pgadmin/tools/backup/static/js/backupGlobal.ui.js(1 hunks)web/pgadmin/tools/debugger/__init__.py(1 hunks)web/pgadmin/tools/erd/static/js/erd_tool/dialogs/OneToOneDialog.js(1 hunks)web/pgadmin/tools/import_export/__init__.py(2 hunks)web/pgadmin/tools/import_export/static/js/import_export.ui.js(4 hunks)web/pgadmin/tools/maintenance/__init__.py(1 hunks)web/pgadmin/tools/maintenance/static/js/maintenance.ui.js(1 hunks)web/pgadmin/tools/psql/static/js/PsqlModule.js(1 hunks)web/pgadmin/tools/sqleditor/static/js/show_view_data.js(1 hunks)web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py(12 hunks)web/pgadmin/tools/user_management/__init__.py(2 hunks)web/pgadmin/utils/__init__.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (29)
web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js (2)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)web/pgadmin/static/js/validators.js (1)
isEmptyString(57-59)
web/pgadmin/tools/psql/static/js/PsqlModule.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/roles/__init__.py (1)
web/pgadmin/utils/ajax.py (1)
gone(153-159)
web/pgadmin/tools/backup/static/js/backupGlobal.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/misc/cloud/static/js/aws_schema.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/misc/cloud/static/js/azure.js (2)
web/pgadmin/misc/cloud/static/js/google.js (1)
_eventBus(26-26)web/pgadmin/static/js/components/FormComponents.jsx (2)
MESSAGE_TYPE(82-88)MESSAGE_TYPE(82-88)
web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_jobs/static/js/dbms_job.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js (3)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)web/pgadmin/browser/static/js/node.js (1)
errmsg(606-606)web/pgadmin/static/js/validators.js (1)
isEmptyString(57-59)
web/pgadmin/browser/static/js/withCheckPermission.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/tools/debugger/__init__.py (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/tools/erd/static/js/erd_tool/dialogs/OneToOneDialog.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_schedules/static/js/dbms_schedule.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/databases/schemas/fts_parsers/__init__.py (1)
web/pgadmin/utils/ajax.py (1)
gone(153-159)
web/pgadmin/tools/sqleditor/static/js/show_view_data.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/tools/maintenance/__init__.py (1)
web/pgadmin/static/js/api_instance.js (1)
errormsg(35-35)
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js (2)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)web/pgadmin/browser/static/js/node.js (1)
errmsg(606-606)
web/pgadmin/tools/import_export/__init__.py (1)
web/pgadmin/utils/ajax.py (1)
bad_request(126-132)
web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/misc/cloud/static/js/azure_schema.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/templates/browser/js/messages.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/tools/maintenance/static/js/maintenance.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py (1)
web/pgadmin/utils/ajax.py (1)
gone(153-159)
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py (2)
web/pgadmin/utils/preferences.py (2)
preference(469-481)register(406-467)web/pgadmin/utils/__init__.py (1)
register(58-83)
web/pgadmin/misc/cloud/static/js/google_schema.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py (2)
web/pgadmin/utils/ajax.py (1)
gone(153-159)web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/tools/import_export/static/js/import_export.ui.js (2)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)web/pgadmin/browser/static/js/node.js (1)
errmsg(606-606)
🪛 GitHub Actions: Check Python style
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py
[error] 139-139: pycodestyle: line too long (80 > 79 characters) [E501]
[error] 322-322: pycodestyle: line too long (80 > 79 characters) [E501]
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: run-python-tests-pg (windows-latest, 18)
- GitHub Check: run-python-tests-pg (windows-latest, 17)
- GitHub Check: run-python-tests-pg (windows-latest, 16)
- GitHub Check: run-python-tests-pg (ubuntu-22.04, 15)
- GitHub Check: run-python-tests-pg (ubuntu-22.04, 14)
- GitHub Check: run-feature-tests-pg (16)
- GitHub Check: run-feature-tests-pg (18)
- GitHub Check: run-feature-tests-pg (15)
- GitHub Check: run-feature-tests-pg (14)
- GitHub Check: run-feature-tests-pg (17)
- GitHub Check: run-feature-tests-pg (13)
🔇 Additional comments (63)
web/pgadmin/browser/templates/browser/js/messages.js (1)
29-29: String punctuation fix is correct and consistentAdding the trailing period to
INVALID_MIN_MAXaligns it with neighboring validation messages and does not affect behavior. Looks good.web/pgadmin/browser/static/js/withCheckPermission.js (1)
22-26: Typographic apostrophe standardization looks good.The change normalizes the apostrophe character in the permission error message to use a standard ASCII escape sequence (
\'), which improves consistency with JavaScript string conventions and ensures proper handling across different environments. The message is clear and thegettext()wrapping ensures proper translation support.web/pgadmin/tools/erd/static/js/erd_tool/dialogs/OneToOneDialog.js (1)
76-76: Approved: Grammar correction improves user-facing error message.The addition of the indefinite article "a" corrects the grammar of the validation error message. The updated message "please select a different constraint." is now grammatically correct and clearer for users.
web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py (1)
716-716: Grammatically correct string corrections approved.The changes from "reversed engineered" to "reverse-engineered" improve the grammar of these user-facing error messages. "Reverse-engineered" is the correct hyphenated form when used as a compound adjective. The strings remain properly wrapped with
gettext()for i18n support, maintaining translation consistency.Also applies to: 721-722
web/pgadmin/tools/debugger/__init__.py (1)
215-215: Good consistency improvement.The change from "Switch Panel" to "Switch panel" aligns this keyboard shortcut label with the sentence-case pattern used throughout the file for similar multi-word labels (e.g., "Step into", "Step over", "Toggle breakpoint", "Clear all breakpoints", "Edit grid values"). This improves UI text consistency without affecting functionality.
web/pgadmin/tools/psql/static/js/PsqlModule.js (1)
84-95: PSQL tool disabled-message text looks goodThe updated
data_disabledstring is grammatically correct and now consistently refers to the “PSQL Tool”, matching the menu label at Line 91, with no behavioral impact.web/pgadmin/browser/server_groups/servers/__init__.py (1)
2044-2047: Improved pgpass error log messageThe updated log text “Unable to fetch pgpass status” is grammatically correct and clearer, with no impact on behavior. Change looks good.
web/pgadmin/utils/__init__.py (1)
352-352: LGTM! Grammatical improvement.The change from "can not" to "cannot" is correct. The single-word form is the standard in English and improves the professionalism of user-facing error messages.
web/pgadmin/tools/import_export/__init__.py (1)
299-301: Updated “specified server” wording is clear and consistentThe change to
"Could not find the specified server."is grammatically better and matches the terminology used in the maintenance module, with no impact on control flow. Looks good.web/pgadmin/tools/maintenance/__init__.py (1)
178-182: Server-not-found message refinement aligns with other toolsThe revised
"Could not find the specified server."string is clearer English and now matches the import/export module’s wording, while keeping the JSON response structure unchanged. No issues from a behavior standpoint.web/pgadmin/tools/user_management/__init__.py (2)
599-600: LGTM! Grammar and clarity improved.The error message now reads more naturally and accurately describes the uniqueness constraint. The change from "email/username" to "email or username" and "for an authentication source" to "for each authentication source" improves both grammar and clarity.
721-721: LGTM! Grammar corrected.The error message now uses correct grammar. The change from "is not allowed to modify" to "cannot be modified" fixes the awkward phrasing and makes the message more natural and professional.
web/pgadmin/tools/import_export/static/js/import_export.ui.js (4)
138-138: LGTM! Grammatical improvement.The correction to "column's input value" (possessive form) is grammatically correct.
274-274: LGTM! Help text refinement.The help message text is clear and grammatically correct.
320-320: LGTM! Proper capitalization.The lowercase "a" before "SELECT" is correct since it's mid-sentence, not at the beginning.
410-410: LGTM! Correct word form."Cannot" (one word) is the correct standard form rather than "can not" (two words).
web/pgadmin/tools/maintenance/static/js/maintenance.ui.js (1)
256-272: BUFFER USAGE LIMIT help text punctuation looks goodPurely textual improvement; wording and units list are clear and consistent, and there’s no impact on behavior.
web/pgadmin/browser/server_groups/servers/roles/__init__.py (1)
905-916: Reverse‑engineered query error messages updated correctlyHyphenation and wording are improved (“reverse‑engineered”) with format placeholders preserved; no logic or error‑handling change.
web/pgadmin/tools/backup/static/js/backupGlobal.ui.js (1)
92-98: Globals backup note punctuation is consistentThe added period makes the note consistent with nearby texts; semantics and behavior are unchanged.
web/pgadmin/authenticate/mfa/views.py (1)
171-177: “Already registered” MFA message and category changeThe updated text and added period read well, and using
MessageType.SUCCESSmakes sense if “already registered” is considered a successful state rather than an error.If the intent is more of an informational notice than a success state, you may want to confirm that
SUCCESSis the desired category here (vs. e.g. an info category) so that UI styling matches expectations.web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js (1)
99-108: Account expiry help text grammar fix is correctAdding “the” (“then the password will never expire”) improves readability without affecting any behavior.
web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_jobs/static/js/dbms_job.ui.js (1)
171-177: DBMS job time validation message punctuation is fineThe updated “Start time must be less than end time.” message is clear and correctly tied to the existing
end_time_js.isBefore(start_time_js)check.web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js (1)
222-227: On‑error validation message grammar improved correctly“Please select a valid on error option.” is grammatically correct and clearly references the “On error” field; no change to validation behavior.
web/pgadmin/tools/sqleditor/static/js/show_view_data.js (1)
64-70: Data filter empty‑state message wording is correct“Data filter cannot be empty.” is grammatically correct, and the validation flow (
setError+return true) is unchanged.web/pgadmin/misc/cloud/static/js/azure.js (1)
34-35: Azure auth progress message reads clearlyThe updated text is grammatically correct and clearer while preserving the existing behavior and markup structure. No functional concerns.
web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_schedules/static/js/dbms_schedule.ui.js (1)
79-81: End-time validation message punctuation is consistentThe revised message “Start time must be less than end time.” is grammatically correct and matches similar validations elsewhere. Logic is unchanged.
web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py (1)
758-760: Reverse‑engineered SQL messages correctedThe updated phrasing “reverse-engineered query” is correct and reads naturally in both error paths, with no behavioral impact.
Also applies to: 765-767
web/pgadmin/misc/cloud/static/js/azure_schema.ui.js (1)
721-725: Cluster name validation text matches ruleThe error message correctly reflects the actual validation (min length 3, only lowercase letters, digits, and hyphens). No change in behavior.
web/pgadmin/browser/register_browser_preferences.py (1)
58-60: Browser preferences help text is clearer and consistentAll updated help strings here read naturally, fix prior awkward phrasing (“that selected schema(s) only”, etc.), and keep preference behavior unchanged. No further changes needed.
Also applies to: 78-80, 116-118, 413-415, 423-426, 435-438, 448-452, 472-475, 493-497
web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js (1)
254-256: pgAgent end-time message aligned with other schedulersThe punctuation fix to “Start time must be less than end time.” is correct and consistent with the DBMS scheduler messages.
web/pgadmin/misc/cloud/static/js/google_schema.ui.js (1)
508-508: LGTM! Proper sentence spacing.The addition of a space after the period correctly separates two sentences in the validation message.
web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js (2)
412-412: LGTM! Consistent validation message punctuation.Adding the trailing period aligns with standard punctuation for complete sentences in error messages.
815-821: LGTM! Consistent error message punctuation.Both validation messages now properly end with periods, maintaining consistency across the codebase.
web/pgadmin/misc/bgprocess/processes.py (2)
696-697: LGTM! Clearer error message.The rewording makes the error message more direct and concise while maintaining clarity.
905-906: LGTM! Consistent error message punctuation.Adding the trailing period maintains consistency with other error messages in the codebase.
web/pgadmin/misc/cloud/static/js/google.js (1)
35-35: LGTM! Fixed punctuation typo.Correcting the double period to a single period with proper spacing improves the user-facing message.
web/pgadmin/browser/server_groups/servers/databases/schemas/fts_parsers/__init__.py (1)
886-895: LGTM! Corrected grammatical error.The term "reverse-engineered" is the correct grammatical form (hyphenated past participle used as an adjective). The previous "reversed engineered" was incorrect. Both error messages now use proper grammar and consistent article usage.
web/pgadmin/browser/server_groups/servers/databases/schemas/fts_configurations/__init__.py (1)
945-954: LGTM! Corrected grammatical error.Consistent with the fix in fts_parsers/init.py, "reverse-engineered" is the proper grammatical form. The corrections improve message accuracy and maintain consistency across similar error messages.
web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js (4)
188-188: LGTM! Consistent help message punctuation.Adding the trailing period maintains consistency with other help messages throughout the codebase.
319-335: LGTM! Consistent help message punctuation.Both help messages now properly end with periods, maintaining uniform formatting across UI strings.
486-486: LGTM! Consistent help message punctuation.Adding the trailing period maintains consistency with other help messages.
494-494: LGTM! Corrected conjunction usage.Changing "Either Host name, Address" to "Either Host name or Address" is grammatically correct. The "either...or" construction is the proper correlative conjunction pair in English.
web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js (5)
57-57: LGTM! Consistent help message punctuation.Adding the trailing period maintains consistency with standard punctuation for complete sentences.
99-99: LGTM! Consistent help message punctuation.The trailing period properly terminates the sentence in the help message.
131-137: LGTM! Consistent help message punctuation.Both help messages now properly end with periods, maintaining uniform formatting.
165-165: LGTM! Corrected word form and punctuation.Changing "can not" to "cannot" is correct—the single-word form is standard in English. The added period properly terminates the error message.
171-171: LGTM! Corrected word form and punctuation.Consistent with line 165, "cannot" is the proper single-word form, and the trailing period maintains punctuation consistency.
web/pgadmin/browser/register_editor_preferences.py (1)
333-334: LGTM!The grammatical improvements are appropriate—capitalizing the sentence start and adding the article "a" enhances clarity.
web/pgadmin/dashboard/__init__.py (3)
102-103: LGTM!The label text is more concise while maintaining clarity.
199-199: LGTM!Correct grammar fix—"each" requires the singular form "line."
206-208: LGTM!The grammatical improvements—adding the article "a," changing "giving" to "showing," and adding proper punctuation—enhance clarity.
web/pgadmin/tools/sqleditor/utils/query_tool_preferences.py (12)
59-59: LGTM!Correct capitalization of the WAL (Write-Ahead Log) acronym.
107-108: LGTM!Adding "the" before "user" improves grammatical correctness.
128-129: LGTM!Consistent with the grammar improvements throughout the file.
150-151: LGTM!Adding "the" improves grammatical consistency.
171-172: LGTM!The capitalization and article additions improve consistency and readability.
182-183: LGTM!Grammar improvement adds clarity.
193-196: LGTM!The improved sentence structure and article additions enhance clarity.
299-302: LGTM!The capitalization maintains consistency with the UI option values.
313-313: LGTM!Consistent capitalization of UI option references.
332-333: LGTM!The text formatting is correct and maintains consistency.
340-341: LGTM!The text improvement enhances clarity.
747-748: LGTM!The grammar improvement—changing "Keywords" to lowercase and refining the phrase—enhances readability.
|
This PR has has conflicts, needs to be fixed. |
dpage
force-pushed
the
javascript_string_cleanup
branch
from
69efc57 to
a3be849
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
671-683:depsforif_existsfield is likely mis-specified and breaks dependency updates
depsis declared as a single string'only_data, include_drop_database'instead of two separate dependency keys. This likely prevents theif_existsfield from re-evaluating itsdisabledstate whenonly_dataorinclude_drop_databasechange.Recommend splitting the dependencies into two entries:
id: 'if_exists', label: gettext('Include IF EXISTS clause'), type: 'switch', group: gettext('Query Options'), - deps: ['only_data, include_drop_database'], + deps: ['only_data', 'include_drop_database'], disabled: function(state) {
🧹 Nitpick comments (2)
web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js (1)
222-224: Grammar fix looks good; consider slightly simpler wordingThe updated message is grammatically correct and clearly an improvement over the previous text. If you want to align even more closely with the nearby messages’ style, you could drop “valid” and use:
- setError('jstonerror', gettext('Please select a valid on error option.')); + setError('jstonerror', gettext('Please select an on error option.'));Not required, just a copy polish suggestion.
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
743-747: Help text is improved; consider a slightly clearer phrasingThe updated help text is grammatically better than the previous version. For even clearer, more natural wording, you might consider:
- helpMessage: gettext('If Schema(s) is selected then it will take the backup of the selected schema(s) only.'), + helpMessage: gettext('If Schema(s) is selected, only the selected schema(s) will be backed up.'),This removes the vague “it” subject and the slightly awkward “take the backup of”.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_jobs/static/js/dbms_job.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_schedules/static/js/dbms_schedule.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js(2 hunks)web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js(4 hunks)web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js(1 hunks)web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js(4 hunks)web/pgadmin/browser/static/js/withCheckPermission.js(1 hunks)web/pgadmin/browser/templates/browser/js/messages.js(1 hunks)web/pgadmin/misc/cloud/static/js/aws_schema.ui.js(1 hunks)web/pgadmin/misc/cloud/static/js/azure.js(1 hunks)web/pgadmin/misc/cloud/static/js/azure_schema.ui.js(2 hunks)web/pgadmin/misc/cloud/static/js/google.js(2 hunks)web/pgadmin/misc/cloud/static/js/google_schema.ui.js(2 hunks)web/pgadmin/tools/backup/static/js/backup.ui.js(2 hunks)web/pgadmin/tools/backup/static/js/backupGlobal.ui.js(1 hunks)web/pgadmin/tools/erd/static/js/erd_tool/dialogs/OneToOneDialog.js(1 hunks)web/pgadmin/tools/import_export/static/js/import_export.ui.js(4 hunks)web/pgadmin/tools/maintenance/static/js/maintenance.ui.js(1 hunks)web/pgadmin/tools/psql/static/js/PsqlModule.js(1 hunks)web/pgadmin/tools/sqleditor/static/js/show_view_data.js(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (18)
- web/pgadmin/tools/backup/static/js/backupGlobal.ui.js
- web/pgadmin/misc/cloud/static/js/azure.js
- web/pgadmin/tools/import_export/static/js/import_export.ui.js
- web/pgadmin/browser/static/js/withCheckPermission.js
- web/pgadmin/misc/cloud/static/js/google_schema.ui.js
- web/pgadmin/tools/sqleditor/static/js/show_view_data.js
- web/pgadmin/tools/psql/static/js/PsqlModule.js
- web/pgadmin/browser/templates/browser/js/messages.js
- web/pgadmin/tools/maintenance/static/js/maintenance.ui.js
- web/pgadmin/tools/erd/static/js/erd_tool/dialogs/OneToOneDialog.js
- web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js
- web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_schedules/static/js/dbms_schedule.ui.js
- web/pgadmin/browser/server_groups/servers/roles/static/js/role.ui.js
- web/pgadmin/browser/server_groups/servers/databases/schemas/types/static/js/type.ui.js
- web/pgadmin/misc/cloud/static/js/google.js
- web/pgadmin/misc/cloud/static/js/azure_schema.ui.js
- web/pgadmin/misc/cloud/static/js/aws_schema.ui.js
- web/pgadmin/browser/server_groups/servers/databases/dbms_job_scheduler/dbms_jobs/static/js/dbms_job.ui.js
🧰 Additional context used
🧬 Code graph analysis (4)
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.ui.js (1)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)
web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js (3)
web/regression/javascript/fake_gettext.js (1)
gettext(40-42)web/pgadmin/browser/static/js/node.js (1)
errmsg(606-606)web/pgadmin/static/js/validators.js (1)
isEmptyString(57-59)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: run-feature-tests-pg (18)
- GitHub Check: run-feature-tests-pg (13)
- GitHub Check: run-feature-tests-pg (14)
- GitHub Check: run-feature-tests-pg (17)
- GitHub Check: run-feature-tests-pg (16)
- GitHub Check: run-feature-tests-pg (15)
- GitHub Check: run-python-tests-pg (macos-latest, 18)
- GitHub Check: run-python-tests-pg (windows-latest, 17)
- GitHub Check: run-python-tests-pg (windows-latest, 14)
- GitHub Check: run-python-tests-pg (windows-latest, 15)
- GitHub Check: run-python-tests-pg (macos-latest, 15)
🔇 Additional comments (7)
web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.ui.js (1)
255-255: LGTM! Improved clarity and consistency.The change from "less than" to "earlier than" is more natural for time comparisons, and adding the trailing period makes this validation message consistent with others in the file (lines 57, 239).
web/pgadmin/browser/server_groups/servers/roles/static/js/roleReassign.js (5)
45-58: Operation toggle help text punctuation looks goodThe updated helpMessage has clearer wording and consistent sentence termination; no behavioral impact.
60-109: “Reassign objects to” help text refinement is fineEnding the description with a period and keeping the wording as-is is consistent with the rest of the dialog.
126-132: Cascade help text is clearer and matches typical PostgreSQL wordingThe CASCADE explanation is accurate and the full sentence with a period improves readability.
134-156: “From database” help text is precise and consistentThe description “Target database on which the operation will be carried out.” is grammatically correct and matches the field purpose.
160-177: Validation messages: “can not” → “cannot” and terminal periodsBoth validation strings are now grammatically correct (“cannot”) and end with periods; escaping of single quotes remains valid and there’s no change to logic.
web/pgadmin/tools/backup/static/js/backup.ui.js (1)
597-604: Server note punctuation change is correct and consistentAdding the trailing period to the
server_notetext improves consistency with other user-facing messages and does not affect behavior.
2 participants
The PR fixes various grammatical issues in Javascript strings.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.