-
Notifications
You must be signed in to change notification settings - Fork 12
chore: make initial_tasks NULL by default to indicate 'unknown yet' #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 09-15-complete-cascade
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
View your CI Pipeline Execution ↗ for commit 2b71eb5
☁️ Nx Cloud last updated this comment at |
3de38b1
to
de5ffae
Compare
de5ffae
to
2b71eb5
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-215.pgflow.pages.dev 📝 Details:
_Last updated: _ |
🔍 Preview Deployment: Playground✅ Deployment successful! 🔗 Preview URL: https://pr-215--pgflow-demo.netlify.app 📝 Details:
_Last updated: _ |
TL;DR
Changed
initial_tasks
from hardcoded "1" toNULL
for dependent map steps, improving semantic correctness.What changed?
NULL
values forinitial_tasks
in thestep_states
tableinitial_tasks
is notNULL
when a step is startedinitial_tasks = NULL
for dependent map steps during flow creationNULL
value to the actual array length when dependencies completeNULL
initial_tasks from startingpkgs/core/PLAN_use_null_for_map_initial_tasks.md
to the root directoryHow to test?
pkgs/core/supabase/tests/initial_tasks_null/dependent_maps_null.test.sql
pkgs/core/supabase/tests/start_flow/dependent_map_initial_tasks_null.test.sql
NULL
initial_tasksNULL
is resolved to the correct array lengthNULL
initial_tasksWhy make this change?
This change improves semantic correctness in the system:
NULL
correctly represents "unknown until dependencies complete"